Merge lp:~vthompson/music-app/art-for-empty-playlists into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 775
Merged at revision: 776
Proposed branch: lp:~vthompson/music-app/art-for-empty-playlists
Merge into: lp:music-app/remix
Diff against target: 12 lines (+1/-1)
1 file modified
common/CoverGrid.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/art-for-empty-playlists
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+246063@code.launchpad.net

Commit message

Use music app icon for empty playlist art.

Description of the change

Use music app icon for empty playlist art instead of a blank space.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM simple change :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/CoverGrid.qml'
--- common/CoverGrid.qml 2014-11-11 02:27:28 +0000
+++ common/CoverGrid.qml 2015-01-11 16:36:36 +0000
@@ -60,7 +60,7 @@
60 ? (coverGrid.covers[index].art !== undefined60 ? (coverGrid.covers[index].art !== undefined
61 ? coverGrid.covers[index].art61 ? coverGrid.covers[index].art
62 : "image://albumart/artist=" + coverGrid.covers[index].author + "&album=" + coverGrid.covers[index].album)62 : "image://albumart/artist=" + coverGrid.covers[index].author + "&album=" + coverGrid.covers[index].album)
63 : ""63 : Qt.resolvedUrl("../images/music-app-cover@30.png")
6464
65 // TODO: This should be investigated once http://pad.lv/139136865 // TODO: This should be investigated once http://pad.lv/1391368
66 // is resolved. Once it is, these can either be set to66 // is resolved. Once it is, these can either be set to

Subscribers

People subscribed via source and target branches