Merge lp:~vthompson/music-app/adjust-transparent-bg-height into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 571
Merged at revision: 579
Proposed branch: lp:~vthompson/music-app/adjust-transparent-bg-height
Merge into: lp:music-app/trusty
Diff against target: 65 lines (+6/-6)
3 files modified
MusicAlbums.qml (+1/-1)
MusicStart.qml (+3/-3)
common/AlbumsPage.qml (+2/-2)
To merge this branch: bzr merge lp:~vthompson/music-app/adjust-transparent-bg-height
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+230917@code.launchpad.net

Commit message

* Adjust the size of the transparent background for a label.

Description of the change

Adjust the size of the transparent background for a label. Currently the top of the background and the label are too close. This MP adjusts some of the ones that seem problematic.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Looks good :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'MusicAlbums.qml'
--- MusicAlbums.qml 2014-08-09 22:52:40 +0000
+++ MusicAlbums.qml 2014-08-15 01:51:59 +0000
@@ -97,7 +97,7 @@
97 left: parent.left97 left: parent.left
98 right: parent.right98 right: parent.right
99 }99 }
100 height: units.gu(5)100 height: units.gu(6)
101 clip: true101 clip: true
102 UbuntuShape{102 UbuntuShape{
103 anchors {103 anchors {
104104
=== modified file 'MusicStart.qml'
--- MusicStart.qml 2014-08-14 18:06:55 +0000
+++ MusicStart.qml 2014-08-15 01:51:59 +0000
@@ -144,7 +144,7 @@
144 left: parent.left144 left: parent.left
145 right: parent.right145 right: parent.right
146 }146 }
147 height: units.gu(5)147 height: units.gu(6)
148 clip: true148 clip: true
149 UbuntuShape{149 UbuntuShape{
150 anchors {150 anchors {
@@ -324,7 +324,7 @@
324 left: parent.left324 left: parent.left
325 right: parent.right325 right: parent.right
326 }326 }
327 height: units.gu(5)327 height: units.gu(5.5)
328 clip: true328 clip: true
329 UbuntuShape{329 UbuntuShape{
330 anchors {330 anchors {
@@ -458,7 +458,7 @@
458 left: parent.left458 left: parent.left
459 right: parent.right459 right: parent.right
460 }460 }
461 height: units.gu(5)461 height: units.gu(6)
462 clip: true462 clip: true
463 UbuntuShape{463 UbuntuShape{
464 anchors {464 anchors {
465465
=== modified file 'common/AlbumsPage.qml'
--- common/AlbumsPage.qml 2014-08-09 22:52:40 +0000
+++ common/AlbumsPage.qml 2014-08-15 01:51:59 +0000
@@ -82,7 +82,7 @@
82 left: parent.left82 left: parent.left
83 right: parent.right83 right: parent.right
84 }84 }
85 height: units.gu(10)85 height: units.gu(11)
86 clip: true86 clip: true
87 UbuntuShape{87 UbuntuShape{
88 anchors {88 anchors {
@@ -117,7 +117,7 @@
117 left: parent.left117 left: parent.left
118 leftMargin: units.gu(1)118 leftMargin: units.gu(1)
119 bottom: parent.bottom119 bottom: parent.bottom
120 bottomMargin: units.gu(5)120 bottomMargin: units.gu(4.5)
121 right: parent.right121 right: parent.right
122 rightMargin: units.gu(1)122 rightMargin: units.gu(1)
123 }123 }

Subscribers

People subscribed via source and target branches

to status/vote changes: