Code review comment for lp:~vrt-openerp/openobject-addons/vrt-openerp

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello Stuart,

The proposed patches sound good, but the merge proposal is hard to review because it seems to contain a certain number of unrelated changes (CRM stuff). As a rule we prefer to keep only related changesets in each merge proposal, especially for bugfix branches - so they can be independently reviewed and merged.
Perhaps the easiest course is to apply your patch for bug 932584 on a fresh copy of our official addons branch, and submit that as a separate merge proposal.

If you'd like more details, our merge proposal documentation includes a step-by-step guide for this process [1].

Thanks for your contributions to OpenERP!

[1] http://doc.openerp.com/v6.0/contribute/15_guidelines/contribution_guidelines.html#merge-proposal-guidelines

review: Needs Resubmitting (branch content)

« Back to merge proposal