Merge lp:~vrruiz/unity-webapps-googlecalendar/const-to-var into lp:unity-webapps-googlecalendar

Proposed by Víctor R. Ruiz
Status: Merged
Approved by: Víctor R. Ruiz
Approved revision: 45
Merged at revision: 44
Proposed branch: lp:~vrruiz/unity-webapps-googlecalendar/const-to-var
Merge into: lp:unity-webapps-googlecalendar
Diff against target: 34 lines (+8/-8)
1 file modified
GoogleCalendar.user.js (+8/-8)
To merge this branch: bzr merge lp:~vrruiz/unity-webapps-googlecalendar/const-to-var
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+168775@code.launchpad.net

Commit message

Fix 'const' error (style_checker).

Description of the change

Fix 'const' error (style_checker).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
45. By Víctor R. Ruiz

Fix this style_checker errors:

GoogleCalendar.user.js:27->Expected 'var' at column 5, not column 9.
GoogleCalendar.user.js:28->Expected 'Unity' at column 5, not column 9.
GoogleCalendar.user.js:32->Expected 'Unity' at column 5, not column 9.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'GoogleCalendar.user.js'
--- GoogleCalendar.user.js 2013-05-01 22:44:10 +0000
+++ GoogleCalendar.user.js 2013-06-12 12:45:32 +0000
@@ -5,7 +5,7 @@
5// ==/UserScript==5// ==/UserScript==
66
7// This placeholder gets munged with real data at build time.7// This placeholder gets munged with real data at build time.
8const WebappsGettextDict = JSON.parse(unescape(8var WebappsGettextDict = JSON.parse(unescape(
9 "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"9 "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"
10));10));
1111
@@ -24,14 +24,14 @@
24}24}
2525
26function doIntegration() {26function doIntegration() {
27 var createButton = document.evaluate('//div[@id="sidebar"]/div[1]/div[1]', document, null, XPathResult.ANY_UNORDERED_NODE_TYPE, null).singleNodeValue;27 var createButton = document.evaluate('//div[@id="sidebar"]/div[1]/div[1]', document, null, XPathResult.ANY_UNORDERED_NODE_TYPE, null).singleNodeValue;
28 Unity.Launcher.addAction(_("Create an event"), function () { launchClickEvent(createButton); });28 Unity.Launcher.addAction(_("Create an event"), function () { launchClickEvent(createButton); });
29}29}
3030
31if (isCorrectPage()) {31if (isCorrectPage()) {
32 Unity.init({name: _("Google Calendar"),32 Unity.init({name: _("Google Calendar"),
33 domain: 'google.com',33 domain: 'google.com',
34 homepage: 'https://www.google.com/calendar/render',34 homepage: 'https://www.google.com/calendar/render',
35 iconUrl: "icon://unity-webapps-google-calendar",35 iconUrl: "icon://unity-webapps-google-calendar",
36 onInit: wrapCallback(doIntegration)});36 onInit: wrapCallback(doIntegration)});
37}37}

Subscribers

People subscribed via source and target branches

to all changes: