GoogleCalendar WebApp

Merge lp:~vrruiz/unity-webapps-googlecalendar/const-to-var into lp:unity-webapps-googlecalendar

  1. const-to-var
  2. Merge into trunk
Proposed by Víctor R. Ruiz
Status: Merged
Approved by: Víctor R. Ruiz
Approved revision: 45
Merged at revision: 44
Proposed branch: lp:~vrruiz/unity-webapps-googlecalendar/const-to-var
Merge into: lp:unity-webapps-googlecalendar
Diff against target: 34 lines (+8/-8)
1 file modified
GoogleCalendar.user.js (+8/-8)
To merge this branch: bzr merge lp:~vrruiz/unity-webapps-googlecalendar/const-to-var
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+168775@code.launchpad.net

Commit message

Fix 'const' error (style_checker).

Description of the change

Fix 'const' error (style_checker).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-saucy-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-saucy-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-googlecalendar-ci/1/rebuild

review: Needs Fixing (continuous-integration)
lp:~vrruiz/unity-webapps-googlecalendar/const-to-var updated
45. By Víctor R. Ruiz

Fix this style_checker errors:

GoogleCalendar.user.js:27->Expected 'var' at column 5, not column 9.
GoogleCalendar.user.js:28->Expected 'Unity' at column 5, not column 9.
GoogleCalendar.user.js:32->Expected 'Unity' at column 5, not column 9.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:45
http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-ci/2/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-saucy-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-saucy-armhf-ci/2

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-googlecalendar-ci/2/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GoogleCalendar.user.js'
2--- GoogleCalendar.user.js 2013-05-01 22:44:10 +0000
3+++ GoogleCalendar.user.js 2013-06-12 12:45:32 +0000
4@@ -5,7 +5,7 @@
5 // ==/UserScript==
6
7 // This placeholder gets munged with real data at build time.
8-const WebappsGettextDict = JSON.parse(unescape(
9+var WebappsGettextDict = JSON.parse(unescape(
10 "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"
11 ));
12
13@@ -24,14 +24,14 @@
14 }
15
16 function doIntegration() {
17- var createButton = document.evaluate('//div[@id="sidebar"]/div[1]/div[1]', document, null, XPathResult.ANY_UNORDERED_NODE_TYPE, null).singleNodeValue;
18- Unity.Launcher.addAction(_("Create an event"), function () { launchClickEvent(createButton); });
19+ var createButton = document.evaluate('//div[@id="sidebar"]/div[1]/div[1]', document, null, XPathResult.ANY_UNORDERED_NODE_TYPE, null).singleNodeValue;
20+ Unity.Launcher.addAction(_("Create an event"), function () { launchClickEvent(createButton); });
21 }
22
23 if (isCorrectPage()) {
24- Unity.init({name: _("Google Calendar"),
25- domain: 'google.com',
26- homepage: 'https://www.google.com/calendar/render',
27- iconUrl: "icon://unity-webapps-google-calendar",
28- onInit: wrapCallback(doIntegration)});
29+ Unity.init({name: _("Google Calendar"),
30+ domain: 'google.com',
31+ homepage: 'https://www.google.com/calendar/render',
32+ iconUrl: "icon://unity-webapps-google-calendar",
33+ onInit: wrapCallback(doIntegration)});
34 }

Subscribers

People subscribed via source and target branches

to all changes: