Merge ~vpa1977/ubuntu/+source/openjdk-17:02_jdk17_specific into ubuntu/+source/openjdk-17:ubuntu/devel

Proposed by Vladimir Petko
Status: Merged
Merged at revision: f89cb32a24814eb7f2fd2b2f851e36f8958d809c
Proposed branch: ~vpa1977/ubuntu/+source/openjdk-17:02_jdk17_specific
Merge into: ubuntu/+source/openjdk-17:ubuntu/devel
Prerequisite: ~vpa1977/ubuntu/+source/openjdk-17:01_tiered_tests
Diff against target: 210 lines (+52/-31)
8 files modified
debian/changelog (+6/-1)
debian/patches/exclude-broken-tests.patch (+14/-7)
debian/patches/series (+0/-2)
debian/patches/update-permission-test.patch (+26/-0)
debian/tests/jtreg-autopkgtest.in (+1/-0)
debian/tests/jtreg-autopkgtest.sh (+1/-0)
debian/tests/problems-i386.txt (+4/-1)
dev/null (+0/-20)
Reviewer Review Type Date Requested Status
Graham Inggs (community) Approve
git-ubuntu import Pending
Review via email: mp+440209@code.launchpad.net

Description of the change

This merge request is a final part of the series [1][2]

Summary of changes:
  * d/t/{jtreg-autopkgtest.in, jtreg-autopkgtest.sh}: pass JTREG home to locate junit.jar.
  * drop d/p/{jaw-classpath.diff, jaw-optional.diff}: the atk wrapper is disabled and these patches cause class data sharing tests to fail.
  * d/p/exclude-broken-tests.patch: add OpenJDK 17 failures.

PPA: ppa:vpa1977/openjdk-tiers2 [4]

Testing:
 - JTREG tests should pass (depends on integration of [2]), see comment

[1] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-17/+git/openjdk-17/+merge/440208
[2] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-17/+git/openjdk-17/+merge/440209
[3] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-20/+git/openjdk-20/+merge/440204
[4] https://launchpad.net/~vpa1977/+archive/ubuntu/openjdk-tiers2

To post a comment you must log in.
Revision history for this message
Vladimir Petko (vpa1977) wrote :
Download full text (27.8 KiB)

amd64 --> /~vpa1977/+archive/ubuntu/openjdk-tiers2/+build/25980172
----------------cut----------------------------------------------
Platform: amd64
--------------- jtreg console summary for hotspot ---------------
Test results: passed: 2,503
[debian/tests/jtreg-autopkgtest.sh] nothing to cleanup
Unable to compare jtreg results: no build jtreport found for hotspot/amd64.
Reason: '/usr/share/doc/openjdk-17-jre-headless//test-amd64/jtreport-hotspot.tar.gz' does not exist.
--------------- jtreg console summary for langtools ---------------
Test results: passed: 4,238
[debian/tests/jtreg-autopkgtest.sh] nothing to cleanup
Unable to compare jtreg results: no build jtreport found for hotspot/amd64.
Reason: '/usr/share/doc/openjdk-17-jre-headless//test-amd64/jtreport-hotspot.tar.gz' does not exist.
--------------- jtreg console summary for jaxp ---------------
Test results: passed: 454
[debian/tests/jtreg-autopkgtest.sh] nothing to cleanup
Unable to compare jtreg results: no build jtreport found for hotspot/amd64.
Reason: '/usr/share/doc/openjdk-17-jre-headless//test-amd64/jtreport-hotspot.tar.gz' does not exist.
--------------- jtreg console summary for jdk ---------------
(xfwm4:1672759): dbind-WARNING **: 05:29:27.971: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
(xfwm4:1672759): xfwm4-WARNING **: 05:29:28.475: Another compositing manager is running on screen 0
(xfwm4:1672759): xfwm4-WARNING **: 05:29:28.477: Failed to connect to session manager: Failed to connect to the session manager: SESSION_MANAGER environment variable not defined
Test results: passed: 5,857
[debian/tests/jtreg-autopkgtest.sh] nothing to cleanup
Unable to compare jtreg results: no build jtreport found for hotspot/amd64.
Reason: '/usr/share/doc/openjdk-17-jre-headless//test-amd64/jtreport-hotspot.tar.gz' does not exist.
Killed
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
 Command being timed: "/usr/bin/make -f debian/rules -k jtregcheck TEST_SUITES=hotspot langtools jaxp jdk JTREG_OPTIONS="
 User time (seconds): 29168.95
 System time (seconds): 1819.27
 Percent of CPU this job got: 331%
 Elapsed (wall clock) time (h:mm:ss or m:ss): 2:35:58
 Average shared text size (kbytes): 0
 Average unshared data size (kbytes): 0
 Average stack size (kbytes): 0
 Average total size (kbytes): 0
 Maximum resident set size (kbytes): 7406384
 Average resident set size (kbytes): 0
 Major (requiring I/O) page faults: 598
 Minor (reclaiming a frame) page faults: 407397440
 Voluntary context switches: 77216292
 Involuntary context switches: 46706555
 Swaps: 0
 File system inputs: 2016200
 File system outputs: 174756632
 Socket messages sent: 0
 Socket messages received: 0
 Signals delivered: 0
 Page size (bytes): 4096
 Exit status: 0
--------------- jtreg console summary for hotspot ---------------
Test results: passed: 2,503
[debian/tests/jtreg-autopkgtest.sh] nothing to cleanup
Unable to compare jtreg results: no build jtreport found for hotspot/amd64.
Reason: '/usr/share/doc/openjdk-17-jre-headless//test-amd64/jtreport-hotspot.tar.gz' does not exist.
--------------- jtreg console summa...

Revision history for this message
Graham Inggs (ginggs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index d674951..af2894b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,4 +1,4 @@
6-openjdk-17 (17.0.6+10-1ubuntu3) UNRELEASED; urgency=medium
7+openjdk-17 (17.0.6+10-1ubuntu3) lunar; urgency=medium
8
9 * d/control: add jtreg6 dependencies, regenerate control.
10 * d/t/{jdk,hotspot,jaxp,lantools}: run tier1 and tier2 jtreg tests only,
11@@ -18,6 +18,11 @@ openjdk-17 (17.0.6+10-1ubuntu3) UNRELEASED; urgency=medium
12 patches to workaround missing DNS resolver on the build machines.
13 - exclude_broken_tests.patch: quarantine failing tests.
14 * d/rules: package external debug symbols (LP: #2015835).
15+ * drop d/p/{jaw-classpath.diff, jaw-optional.diff}: the atk wrapper is disabled
16+ and these patches cause class data sharing tests to fail (LP: #2016194).
17+ * d/p/exclude-broken-tests.patch: add OpenJDK 17 failures.
18+ * d/t/jtreg-autopkgtest.in: pass JTREG home to locate junit.jar, regenerate
19+ d/t/jtreg-autopkgtest.sh (LP: #2016206).
20
21 -- Vladimir Petko <vladimir.petko@canonical.com> Mon, 27 Mar 2023 11:41:46 +1300
22
23diff --git a/debian/patches/exclude-broken-tests.patch b/debian/patches/exclude-broken-tests.patch
24index 2b846bc..0eb04d5 100644
25--- a/debian/patches/exclude-broken-tests.patch
26+++ b/debian/patches/exclude-broken-tests.patch
27@@ -5,14 +5,10 @@ Forwarded: not-needed
28 Last-Update: 2023-03-24
29 --- a/test/hotspot/jtreg/ProblemList.txt
30 +++ b/test/hotspot/jtreg/ProblemList.txt
31-@@ -38,6 +38,20 @@
32+@@ -38,6 +38,22 @@
33 #
34 #############################################################################
35
36-+# tests broken by Debian-specific patches
37-+
38-+runtime/BootClassAppendProp/GetBootClassPathAppendProp.java 0000000 generic-all
39-+
40 +# tests that need to be investigated
41 +
42 +gc/shenandoah/mxbeans/TestChurnNotifications.java#aggressive 0000000 generic-all
43@@ -23,6 +19,12 @@ Last-Update: 2023-03-24
44 +
45 +runtime/LoadClass/LongBCP.java 8166162 generic-all
46 +
47++# Intermittent failures because LingeredApp.class is not found
48++
49++runtime/cds/appcds/jcmd/JCmdTestDynamicDump.java 000000 generic-all
50++runtime/cds/appcds/jcmd/JCmdTestFileSafety.java 000000 generic-all
51++runtime/cds/appcds/jcmd/JCmdTestStaticDump.java 000000 generic-all
52++
53 # :hotspot_compiler
54
55 compiler/ciReplay/TestSAServer.java 8029528 generic-all
56@@ -42,7 +44,7 @@ Last-Update: 2023-03-24
57 # javadoc
58 --- a/test/jdk/ProblemList.txt
59 +++ b/test/jdk/ProblemList.txt
60-@@ -109,6 +109,44 @@
61+@@ -109,6 +109,49 @@
62 #
63 #############################################################################
64
65@@ -84,10 +86,15 @@ Last-Update: 2023-03-24
66 +
67 +java/lang/invoke/lambda/LambdaFileEncodingSerialization.java 8249079 generic-all
68 +
69++# reproducible-properties-timestamp.diff introduce a bug that breaks this test
70++# remove after the patch is dropped
71++
72++java/util/logging/LogManager/Configuration/updateConfiguration/SimpleUpdateConfigWithInputStreamTest.java 000000 generic-all
73++
74 ############################################################################
75
76 # jdk_awt
77-@@ -539,7 +577,6 @@
78+@@ -539,7 +582,6 @@
79 java/lang/ProcessHandle/InfoTest.java 8211847 aix-ppc64
80 java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java 8151492 generic-all
81 java/lang/invoke/LFCaching/LFGarbageCollectedTest.java 8078602 generic-all
82diff --git a/debian/patches/jaw-classpath.diff b/debian/patches/jaw-classpath.diff
83deleted file mode 100644
84index 5cf865e..0000000
85--- a/debian/patches/jaw-classpath.diff
86+++ /dev/null
87@@ -1,12 +0,0 @@
88-Fix finding the Java ATK wrapper, see #900912
89-
90---- a/src/hotspot/os/linux/os_linux.cpp
91-+++ b/src/hotspot/os/linux/os_linux.cpp
92-@@ -464,6 +464,7 @@
93- if (!set_boot_path('/', ':')) {
94- vm_exit_during_initialization("Failed setting boot class path.", NULL);
95- }
96-+ Arguments::append_sysclasspath("/usr/share/java/java-atk-wrapper.jar");
97- }
98-
99- // Where to look for native libraries.
100diff --git a/debian/patches/jaw-optional.diff b/debian/patches/jaw-optional.diff
101deleted file mode 100644
102index 4eb0636..0000000
103--- a/debian/patches/jaw-optional.diff
104+++ /dev/null
105@@ -1,20 +0,0 @@
106-Make failing to load the Java ATK wrapper non-fatal
107-
108----
109- src/java.desktop/share/classes/java/awt/Toolkit.java | 4 ++++
110- 1 file changed, 4 insertions(+)
111-
112---- a/src/java.desktop/share/classes/java/awt/Toolkit.java
113-+++ b/src/java.desktop/share/classes/java/awt/Toolkit.java
114-@@ -602,7 +602,11 @@ public abstract class Toolkit {
115- toolkit = new HeadlessToolkit(toolkit);
116- }
117- if (!GraphicsEnvironment.isHeadless()) {
118-+ try {
119- loadAssistiveTechnologies();
120-+ } catch (java.awt.AWTError e) {
121-+ // too bad
122-+ }
123- }
124- }
125- return toolkit;
126diff --git a/debian/patches/series b/debian/patches/series
127index d435ec4..1a26e90 100644
128--- a/debian/patches/series
129+++ b/debian/patches/series
130@@ -22,8 +22,6 @@ reproducible-properties-timestamp.diff
131 make-debug-print.diff
132 Don-t-optimize-fdlibm-fork-for-Zero-on-linux-sparc-Z.patch
133 keep-gtk2-as-default.patch
134-jaw-classpath.diff
135-jaw-optional.diff
136 reproducible-character-data.diff
137 reproducible-module-info.diff
138 #reproducible-copyright-headers.diff
139diff --git a/debian/patches/update-permission-test.patch b/debian/patches/update-permission-test.patch
140index 59a28ab..d1437d5 100644
141--- a/debian/patches/update-permission-test.patch
142+++ b/debian/patches/update-permission-test.patch
143@@ -23,3 +23,29 @@ Last-Update: 2023-03-24
144 permissions.add(new ReflectPermission("suppressAccessChecks"));
145 permissions.add(new FilePermission("<<ALL FILES>>",
146 "read, write, delete"));
147+--- a/test/jaxp/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java
148++++ b/test/jaxp/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java
149+@@ -35,6 +35,7 @@
150+ import java.util.HashMap;
151+ import java.util.Map;
152+ import java.util.PropertyPermission;
153++import java.lang.reflect.ReflectPermission;
154+ import java.util.Set;
155+ import java.util.StringJoiner;
156+
157+@@ -110,6 +111,15 @@
158+ addPermission(new SecurityPermission("setPolicy"));
159+ addPermission(new RuntimePermission("setSecurityManager"));
160+ addPermission(new PropertyPermission("test.src", "read"));
161++ addPermission(new PropertyPermission("testng.show.stack.frames", "read"));
162++ addPermission(new PropertyPermission("testng.thread.affinity", "read"));
163++ addPermission(new PropertyPermission("testng.memory.friendly", "read"));
164++ addPermission(new PropertyPermission("testng.mode.dryrun", "read"));
165++ addPermission(new PropertyPermission("testng.report.xml.name", "read"));
166++ addPermission(new PropertyPermission("testng.timezone", "read"));
167++ addPermission(new PropertyPermission("testng.default.verbose", "read"));
168++ addPermission(new PropertyPermission("testng.ignore.callback.skip", "read"));
169++ addPermission(new ReflectPermission("suppressAccessChecks"));
170+ }
171+
172+ /*
173diff --git a/debian/tests/jtreg-autopkgtest.in b/debian/tests/jtreg-autopkgtest.in
174index 24ed777..4b62d12 100755
175--- a/debian/tests/jtreg-autopkgtest.in
176+++ b/debian/tests/jtreg-autopkgtest.in
177@@ -92,6 +92,7 @@ for i in 0 1; do
178 report_path="${i}/JTreport"
179 report_dir="${output_dir}/${report_path}"
180 jtreg ${jt_options} \
181+ -vmoption:-Djtreg.home=/usr/share/jtreg \
182 -verbose:summary \
183 -automatic \
184 -retain:none \
185diff --git a/debian/tests/jtreg-autopkgtest.sh b/debian/tests/jtreg-autopkgtest.sh
186index b828b79..8853da4 100755
187--- a/debian/tests/jtreg-autopkgtest.sh
188+++ b/debian/tests/jtreg-autopkgtest.sh
189@@ -98,6 +98,7 @@ for i in 0 1; do
190 report_dir="${output_dir}/${report_path}"
191 # see make/RunTests.gmk for a set of good options
192 jtreg ${jt_options} \
193+ -J-Djtreg.home=/usr/share/jtreg \
194 -verbose:summary \
195 -automatic \
196 -retain:none \
197diff --git a/debian/tests/problems-i386.txt b/debian/tests/problems-i386.txt
198index 1028756..01f2c91 100644
199--- a/debian/tests/problems-i386.txt
200+++ b/debian/tests/problems-i386.txt
201@@ -10,4 +10,7 @@ gtest/GTestWrapper.java 000000 generic-all
202
203 # : jdk
204
205-tools/jlink/JLinkTest.java 000000 generic-all
206\ No newline at end of file
207+tools/jlink/JLinkTest.java 000000 generic-all
208+
209+java/net/httpclient/http2/HpackBinaryTestDriver.java 000000 generic-all
210+

Subscribers

People subscribed via source and target branches