Code review comment for ~vpa1977/ubuntu/+source/jtreg7:jtreg7-vendor

Revision history for this message
Pushkar Kulkarni (pushkarnk) wrote :

I have gone over this patch a few times and appreciate the outer layers of it. That means I haven't really looked into the specific contents of the various maven.rules, maven.ignoreRules and poms files added here.

I realize this kind of a vendoring solution is essential for the jtreg7 backport, which is going to be critical to regression test JDK 21 (and JDK 17 too, in the near future). It will be interesting to see what approach is agreed upon by Debian in this context.

I approve and also recommend a further review of the solution.

review: Approve

« Back to merge proposal