Merge ~vpa1977/ubuntu/+source/cheshire-clojure:java21-ftbfs into ubuntu/+source/cheshire-clojure:ubuntu/devel

Proposed by Vladimir Petko
Status: Needs review
Proposed branch: ~vpa1977/ubuntu/+source/cheshire-clojure:java21-ftbfs
Merge into: ubuntu/+source/cheshire-clojure:ubuntu/devel
Diff against target: 76 lines (+31/-2)
5 files modified
debian/changelog (+9/-0)
debian/control (+2/-1)
debian/patches/0003-compile-with-jdk21.patch (+17/-0)
debian/patches/series (+1/-0)
debian/rules (+2/-1)
Reviewer Review Type Date Requested Status
Julian Andres Klode (community) Approve
git-ubuntu import Pending
Review via email: mp+460408@code.launchpad.net

Description of the change

This MP resolves Java 21 ftbfs.

PPA: ppa:vpa1977/october-21 [1]

Changes:
 - Use java_compat_level variable provided by java-common to adjust -source/-target level to the minimum required by the default Java

Testing:
 - rebuild in default Java 21 ppa[2]
 - piuparts test [3]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/october-21
[2] https://launchpad.net/~vpa1977/+archive/ubuntu/october-21-2/+sourcepub/15785346/+listing-archive-extra
[3] https://bugs.launchpad.net/ubuntu/+source/cheshire-clojure/+bug/2052757/comments/1

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

Uploaded, thanks

review: Approve

Unmerged commits

51944f1... by Vladimir Petko

changelog

6263d82... by Vladimir Petko

update-maintainer

8563229... by Vladimir Petko

Use JAVA_COMPAT_LEVEL to adjust -source/-target in project.clj

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 7e2e866..fe0d3c6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
1cheshire-clojure (5.11.0-2ubuntu1) noble; urgency=medium
2
3 [ Pushkar Kulkarni ]
4 * debian/patches/0003-compile-with-jdk21.patch: use JAVA_COMPAT_LEVEL
5 environment variable provided by java-common to adjust -source/-target
6 level to the minimum required by the default Java (LP: #2052757).
7
8 -- Vladimir Petko <vladimir.petko@canonical.com> Tue, 13 Feb 2024 10:43:03 +1300
9
1cheshire-clojure (5.11.0-2) unstable; urgency=medium10cheshire-clojure (5.11.0-2) unstable; urgency=medium
211
3 * d/tests: add autopkgtests12 * d/tests: add autopkgtests
diff --git a/debian/control b/debian/control
index a16162e..b070564 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: cheshire-clojure1Source: cheshire-clojure
2Section: java2Section: java
3Priority: optional3Priority: optional
4Maintainer: Debian Clojure Maintainers <team+clojure@tracker.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian Clojure Maintainers <team+clojure@tracker.debian.org>
5Uploaders:6Uploaders:
6 Apollon Oikonomopoulos <apoikos@debian.org>,7 Apollon Oikonomopoulos <apoikos@debian.org>,
7 Jérôme Charaoui <jerome@riseup.net>,8 Jérôme Charaoui <jerome@riseup.net>,
diff --git a/debian/patches/0003-compile-with-jdk21.patch b/debian/patches/0003-compile-with-jdk21.patch
8new file mode 1006449new file mode 100644
index 0000000..5c23b28
--- /dev/null
+++ b/debian/patches/0003-compile-with-jdk21.patch
@@ -0,0 +1,17 @@
1Description: use java_compat_level variable provided by java-common
2 This is a Debian-specific patch to set javac source and target level options
3 using a variable provided by java-common package.
4Author: Pushkar Kulkarni <pushkar.kulkarni@canonical.com>
5Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053016
6Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/cheshire-clojure/+bug/2052757
7Forwarded: not-needed
8Last-Update: 2024-02-09
9--- a/project.clj
10+++ b/project.clj
11@@ -39,5 +39,5 @@
12 ;; "-XX:+UnlockDiagnosticVMOptions"
13 ;; "-XX:+PrintInlining"
14 ]
15- :javac-options ["-target" "1.7" "-source" "1.7" "-Xlint:-options"]
16+ :javac-options ["-target" ~(System/getenv, "JAVA_COMPAT_LEVEL") "-source" ~(System/getenv, "JAVA_COMPAT_LEVEL")]
17 :local-repo "debian/maven-repo")
diff --git a/debian/patches/series b/debian/patches/series
index 53c5240..8878832 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
10001-Lein-Local.patch10001-Lein-Local.patch
20002-Skip-failing-test.generative-testcase.patch20002-Skip-failing-test.generative-testcase.patch
30003-compile-with-jdk21.patch
diff --git a/debian/rules b/debian/rules
index 5940ff3..0e1c6fb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,7 +2,8 @@
22
3include /usr/share/dpkg/pkg-info.mk3include /usr/share/dpkg/pkg-info.mk
4include /usr/share/javahelper/java-vars.mk4include /usr/share/javahelper/java-vars.mk
55include /usr/share/java/java_defaults.mk
6export JAVA_COMPAT_LEVEL=$(java_compat_level)
6export LEIN_HOME=$(CURDIR)/.lein7export LEIN_HOME=$(CURDIR)/.lein
7export LEIN_OFFLINE=true8export LEIN_OFFLINE=true
8NAME=cheshire9NAME=cheshire

Subscribers

People subscribed via source and target branches