Code review comment for lp:~vorlon/xdeb/lp.752287

On Fri, Apr 08, 2011 at 10:28:30AM -0000, Loïc Minier wrote:
> Review: Approve
> review approve

> On Fri, Apr 08, 2011, Steve Langasek wrote:
> > bin_cache = get_output(['apt-cache', apt_opts,
> > - 'show', binary]).splitlines()
> > + 'show',
> > + '%s:%s' % (binary, options.architecture)]).splitlines()

> Looks like last line is a bit too long; please fix before merging

Fixed and pushing, thanks.

> Out of curiosity, does this work with pre-multiarch APTs like lucid's?

Nope, it doesn't. Thanks, added a breaks on old apt for this.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world