Code review comment for lp:~vorlon/xdeb/lp.752287

Revision history for this message
Loïc Minier (lool) wrote :

 review approve

On Fri, Apr 08, 2011, Steve Langasek wrote:
> bin_cache = get_output(['apt-cache', apt_opts,
> - 'show', binary]).splitlines()
> + 'show',
> + '%s:%s' % (binary, options.architecture)]).splitlines()

 Looks like last line is a bit too long; please fix before merging

 Out of curiosity, does this work with pre-multiarch APTs like lucid's?

--
Loïc Minier

review: Approve

« Back to merge proposal