Code review comment for lp:~vorlon/ubuntu-archive-tools/queue-item-scaling

Revision history for this message
Steve Langasek (vorlon) wrote :

On Fri, Aug 03, 2012 at 07:13:19PM -0000, Colin Watson wrote:
> I think this will break ordering in 'queue info'.

Confirmed.

> How about using collections.OrderedDict instead? (Or the collections
> documentation has a link to a recipe for OrderedSet.)

Looks like this works without too much trouble. I don't see any easy way to
test the performance currently, now that the language packs have been
flushed from the queue, but it at least seems to be working reliably.
Pushed an update.

« Back to merge proposal