Merge lp:~vorlon/python/lp.738213 into lp:~doko/python/pkg2.7-debian

Proposed by Steve Langasek
Status: Needs review
Proposed branch: lp:~vorlon/python/lp.738213
Merge into: lp:~doko/python/pkg2.7-debian
Diff against target: 63 lines (+14/-22)
2 files modified
changelog (+9/-0)
patches/deb-setup.diff (+5/-22)
To merge this branch: bzr merge lp:~vorlon/python/lp.738213
Reviewer Review Type Date Requested Status
Matthias Klose Pending
Review via email: mp+54473@code.launchpad.net

Description of the change

Matthias, please review this proposed fix to the python2.7 packaging's
detection of the multiarch path at build time, and if you find it suitable,
please upload.

To post a comment you must log in.
lp:~vorlon/python/lp.738213 updated
55. By Steve Langasek

releasing version 2.7.1-5ubuntu1

Unmerged revisions

55. By Steve Langasek

releasing version 2.7.1-5ubuntu1

54. By Steve Langasek

debian/patches/deb-setup.diff: DEB_GNU_TYPE was never being set, so
the expected multiarch path support wasn't working. Consolidate to
a single call to dpkg-architecture -qDEB_HOST_MULTIARCH in setup.py.
LP: #738213.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'changelog'
--- changelog 2011-02-24 06:44:54 +0000
+++ changelog 2011-03-23 22:05:59 +0000
@@ -1,3 +1,12 @@
1python2.7 (2.7.1-5ubuntu1) natty; urgency=low
2
3 * debian/patches/deb-setup.diff: DEB_GNU_TYPE was never being set, so
4 the expected multiarch path support wasn't working. Consolidate to
5 a single call to dpkg-architecture -qDEB_HOST_MULTIARCH in setup.py.
6 LP: #738213.
7
8 -- Steve Langasek <steve.langasek@ubuntu.com> Wed, 23 Mar 2011 15:02:47 -0700
9
1python2.7 (2.7.1-5) experimental; urgency=low10python2.7 (2.7.1-5) experimental; urgency=low
211
3 * Update to 20110224, taken from the 2.7 branch.12 * Update to 20110224, taken from the 2.7 branch.
413
=== modified file 'patches/deb-setup.diff'
--- patches/deb-setup.diff 2010-11-14 02:51:54 +0000
+++ patches/deb-setup.diff 2011-03-23 22:05:59 +0000
@@ -1,18 +1,10 @@
1# DP: Don't include /usr/local/include and /usr/local/lib as gcc search paths1# DP: Don't include /usr/local/include and /usr/local/lib as gcc search paths
2# DP: Include /usr/include/<triplet> and /usr/lib/<triplet> as gcc search paths2# DP: Include /usr/include/<triplet> and /usr/lib/<triplet> as gcc search paths
33
4--- a/Makefile.pre.in4Index: python2.7-2.7.1/setup.py
5+++ b/Makefile.pre.in5===================================================================
6@@ -207,6 +207,7 @@6--- python2.7-2.7.1.orig/setup.py
7 7+++ python2.7-2.7.1/setup.py
8
9 LIBFFI_INCLUDEDIR= @LIBFFI_INCLUDEDIR@
10+DEB_GNU_TYPE=@DEB_GNU_TYPE@
11
12 ##########################################################################
13 # Parser
14--- a/setup.py
15+++ b/setup.py
16@@ -347,8 +347,12 @@8@@ -347,8 +347,12 @@
17 9
18 def detect_modules(self):10 def detect_modules(self):
@@ -22,18 +14,9 @@
22+ # On Debian /usr/local is always used, so we don't include it twice14+ # On Debian /usr/local is always used, so we don't include it twice
23+ #add_dir_to_list(self.compiler.library_dirs, '/usr/local/lib')15+ #add_dir_to_list(self.compiler.library_dirs, '/usr/local/lib')
24+ #add_dir_to_list(self.compiler.include_dirs, '/usr/local/include')16+ #add_dir_to_list(self.compiler.include_dirs, '/usr/local/include')
25+ triplet = sysconfig.get_config_var("DEB_GNU_TYPE")17+ triplet = os.popen('dpkg-architecture -qDEB_HOST_MULTIARCH').readline()[:-1]
26+ add_dir_to_list(self.compiler.library_dirs, '/usr/lib/%s' % triplet)18+ add_dir_to_list(self.compiler.library_dirs, '/usr/lib/%s' % triplet)
27+ add_dir_to_list(self.compiler.include_dirs, '/usr/include/%s' % triplet)19+ add_dir_to_list(self.compiler.include_dirs, '/usr/include/%s' % triplet)
28 20
29 # Add paths specified in the environment variables LDFLAGS and21 # Add paths specified in the environment variables LDFLAGS and
30 # CPPFLAGS for header and library files.22 # CPPFLAGS for header and library files.
31@@ -408,6 +412,8 @@
32 '/lib', '/usr/lib',
33 ]
34 inc_dirs = self.compiler.include_dirs + ['/usr/include']
35+ gnu_triplet = os.popen('dpkg-architecture -qDEB_HOST_GNU_TYPE').readline()[:-1]
36+ inc_dirs.append(os.path.join('/usr/include', gnu_triplet))
37 exts = []
38 missing = []
39

Subscribers

People subscribed via source and target branches

to all changes: