Merge lp:~vorlon/lp-ftbfs-report/report-only-regressions into lp:~wgrant/lp-ftbfs-report/production

[Steve Langasek]

Currently the archive rebuild reports list build failures that are not regressions vs the main archive. This is pointless redundancy and makes it difficult to identify which results should actually receive attention. The test archive rebuild reports should be focused on doing one thing well, namely identifying packages in the main archive that are not currently maintainable because they fail to build.

If someone feels these build failures should still be shown in the report, then I would at least want to categorize these separately in the output. But I don't think they belong here at all.

[Steve Langasek (vorlon)]

As a data point, a test run of the report for test-rebuild-20180408-bionic resulted in a 16% reduction in packages reported for main (45->36), and a 22% reduction for universe (1285->1002).

[Steve Langasek (vorlon)]

However, I also have at least one bug here, because the brltty build failure is only reported for armhf when it affects all architectures (http://qa.ubuntuwire.org/ftbfs/rebuilds/test-rebuild-20180408-bionic.html).

[Steve Langasek (vorlon)]

ok, the "only reported for armhf" is because (not obviously to me) the results of previous runs are cached in a way that means if you change the list of architectures you're running it for, it doesn't properly update the results.

So the only remaining thing I'm looking at is to check the runtime impact of the added checks.

[lp:~vorlon/lp-ftbfs-report/report-only-regressions]

62. By Steve Langasek on 2018-04-16

cache the walking of build results for the main archive to speed up the report

[Steve Langasek (vorlon)]

New commit speeds up a full report run to where we pay only a ~2.5x runtime penalty for the added processing, instead of ~3.3x. I don't see an obvious way to eke out much more.

Saw some failures incorrectly go missing from the report earlier in testing which I can now no longer reproduce. But this may be worth spot-checking a few more runs before landing.

Presently, the amended results are 40->38 packages for main (only firefox and thunderbird now dropped out), but 1424->1152 for universe.

=== modified file 'source/build_status.py'
--- source/build_status.py	2018-04-13 08:43:59 +0000
+++ source/build_status.py	2018-04-16 19:53:26 +0000
@@ -149,6 +149,7 @@
         else:
             return list(self.packagesets.difference((name,)))
 
+<<<<<<< TREE
     def getTeams(self, name=None):
         '''Return the list of teams without the team `name`.'''
         if name is None:
@@ -156,6 +157,36 @@
         else:
             return list(self.teams.difference((name,)))
 
+=======
+class BuildsForMain(object):
+    _cache = dict()
+
+    def __new__(cls, source, version):
+        try:
+            return cls._cache["%s,%s" % (source, version)]
+        except KeyError:
+            bfm = super(BuildsForMain, cls).__new__(cls)
+            results = {}
+            main_archive = launchpad.distributions['ubuntu'].main_archive
+            sourcepubs = main_archive.getPublishedSources(
+                exact_match=True, source_name=source, version=version)
+            for pub in sourcepubs:
+                for build in pub.getBuilds():
+                    # assumes sourcepubs are sorted latest release to oldest,
+                    # so first record wins
+                    if build.arch_tag not in results:
+                        results[build.arch_tag] = build.buildstate
+            bfm.results = results
+            # add to cache
+            cls._cache["%s,%s" % (source, version)] = bfm
+
+            return bfm
+
+    @classmethod
+    def clear(cls):
+        cls._cache.clear()
+
+>>>>>>> MERGE-SOURCE
 class SPPH(object):
     _cache = dict() # dict with all SPPH objects
 
@@ -298,6 +329,19 @@
 
         if not spph.current:
             print "    superseded"
+
+        if main_archive:
+            # If this build failure is not a regression versus the
+            # main archive, do not report it.
+            main_builds = BuildsForMain(spph._lp.source_package_name,
+                                        spph._lp.source_package_version)
+            try:
+                if main_builds.results[arch] != 'Successfully built':
+                    print "  Skipping %s" % build.title
+                    continue
+            except KeyError:
+                pass
+
         SPPH(csp_link).addBuildLog(build)
 
     return cur_last_published