Code review comment for lp:~vorlon/livecd-rootfs/minimize-round-two

Revision history for this message
Steve Langasek (vorlon) wrote :

On Thu, Oct 26, 2017 at 02:31:01PM -0000, Chris Glass wrote:
> Xenial FTB even when removing publicsuffix from the list of packages to remove:

> https://pastebin.canonical.com/201731/

This seems to be some sort of mis-merge.
lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed has the following in
live-build/ubuntu-cpc/hooks/032-disk-image.binary:

create_empty_partition_table() {
    apt-get install -qqy parted

    parted "$1" --script -- mklabel msdos
}

Your pastebin output clearly shows that the call to apt-get is missing:

+ create_empty_partition_table binary/boot/disk.ext4
+ parted binary/boot/disk.ext4 --script -- mklabel msdos

Some sort of local damage to your branch? Cosmic rays?

« Back to merge proposal