Merge lp:~vorlon/livecd-rootfs/image-flavors into lp:livecd-rootfs

Proposed by Steve Langasek
Status: Merged
Merged at revision: 1462
Proposed branch: lp:~vorlon/livecd-rootfs/image-flavors
Merge into: lp:livecd-rootfs
Diff against target: 117 lines (+53/-1) (has conflicts)
6 files modified
debian/changelog (+3/-0)
live-build/ubuntu-cpc/hooks/032-root-squashfs.binary (+9/-0)
live-build/ubuntu-cpc/hooks/040-qcow2-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/040-vmdk-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary (+14/-1)
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+9/-0)
Text conflict in live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary
To merge this branch: bzr merge lp:~vorlon/livecd-rootfs/image-flavors
Reviewer Review Type Date Requested Status
Dan Watkins (community) Approve
Adam Conrad Pending
Review via email: mp+316530@code.launchpad.net
To post a comment you must log in.
1458. By Steve Langasek

Fix gratuitous quoting bug

Revision history for this message
Dan Watkins (oddbloke) wrote :

LGTM

review: Approve
1459. By Steve Langasek

Always export LB_IMAGE_FLAVORS, so that hooks don't complain about unbound variables

1460. By Steve Langasek

Per discussion with Adam, don't make this an LB_ variable since it's not actually part of live-build; instead we will look to pass it into the environment through launchpad-buildd

1461. By Steve Langasek

vmdk-ova has to key on the vmdk image build

1462. By Steve Langasek

Also make squashfs skippable with $IMAGE_TARGETS

1463. By Steve Langasek

merge from trunk

Revision history for this message
Colin Watson (cjwatson) :
Revision history for this message
Colin Watson (cjwatson) :
1464. By Steve Langasek

fix the changelog to match the implementation, thanks to Colin for catching

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2017-02-17 22:30:31 +0000
+++ debian/changelog 2017-02-28 06:31:36 +0000
@@ -7,6 +7,9 @@
7 * live-build/ubuntu-cpc/functions: umount_partition: don't call7 * live-build/ubuntu-cpc/functions: umount_partition: don't call
8 umount_settle for each submount; just unmount them one by one and8 umount_settle for each submount; just unmount them one by one and
9 settle at the end.9 settle at the end.
10 * Support passing IMAGE_TARGETS in the environment, to limit which images
11 are output as part of a build; particularly useful for ubuntu-cpc builds
12 which output multiple image types.
1013
11 [ Nishanth Aravamudan ]14 [ Nishanth Aravamudan ]
12 * live-build/ubuntu-cpc/hooks/061-open-iscsi.chroot: generate iSCSI15 * live-build/ubuntu-cpc/hooks/061-open-iscsi.chroot: generate iSCSI
1316
=== modified file 'live-build/ubuntu-cpc/hooks/032-root-squashfs.binary'
--- live-build/ubuntu-cpc/hooks/032-root-squashfs.binary 2016-06-09 09:47:25 +0000
+++ live-build/ubuntu-cpc/hooks/032-root-squashfs.binary 2017-02-28 06:31:36 +0000
@@ -3,6 +3,15 @@
3#3#
4# Generate a squashfs root and manifest4# Generate a squashfs root and manifest
55
6case $IMAGE_TARGETS in
7 ""|*squashfs*)
8 ;;
9 *)
10 echo "Skipping squashfs build"
11 exit 0
12 ;;
13esac
14
6if [ -n "$SUBARCH" ]; then15if [ -n "$SUBARCH" ]; then
7 echo "Skipping rootfs build for subarch flavor build"16 echo "Skipping rootfs build for subarch flavor build"
8 exit 017 exit 0
918
=== modified file 'live-build/ubuntu-cpc/hooks/040-qcow2-image.binary'
--- live-build/ubuntu-cpc/hooks/040-qcow2-image.binary 2016-06-09 09:47:25 +0000
+++ live-build/ubuntu-cpc/hooks/040-qcow2-image.binary 2017-02-28 06:31:36 +0000
@@ -1,5 +1,14 @@
1#!/bin/bash -ex1#!/bin/bash -ex
22
3case $IMAGE_TARGETS in
4 ""|*qcow2*)
5 ;;
6 *)
7 echo "Skipping qcow2 image build"
8 exit 0
9 ;;
10esac
11
3case $ARCH:$SUBARCH in12case $ARCH:$SUBARCH in
4 # Not sure if any other cloud images use subarch for something that13 # Not sure if any other cloud images use subarch for something that
5 # should take qcow2 format, so only skipping this on raspi2 for now.14 # should take qcow2 format, so only skipping this on raspi2 for now.
615
=== modified file 'live-build/ubuntu-cpc/hooks/040-vmdk-image.binary'
--- live-build/ubuntu-cpc/hooks/040-vmdk-image.binary 2016-06-09 09:47:25 +0000
+++ live-build/ubuntu-cpc/hooks/040-vmdk-image.binary 2017-02-28 06:31:36 +0000
@@ -9,6 +9,15 @@
9 exit 0;;9 exit 0;;
10esac10esac
1111
12case ${IMAGE_TARGETS:-} in
13 ""|*vmdk*)
14 ;;
15 *)
16 echo "Skipping VMDK image build"
17 exit 0
18 ;;
19esac
20
12. /build/config/functions21. /build/config/functions
1322
14if [ -e binary/boot/disk-uefi.ext4 ]; then23if [ -e binary/boot/disk-uefi.ext4 ]; then
1524
=== modified file 'live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary'
--- live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary 2017-02-16 17:04:07 +0000
+++ live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary 2017-02-28 06:31:36 +0000
@@ -26,7 +26,20 @@
26 echo "OVA images are not supported for $ARCH yet.";26 echo "OVA images are not supported for $ARCH yet.";
27 exit 0;;27 exit 0;;
28esac28esac
2929<<<<<<< TREE
30
31=======
32
33case ${IMAGE_TARGETS:-} in
34 ""|*vmdk*)
35 ;;
36 *)
37 echo "Skipping OVA image build"
38 exit 0
39 ;;
40esac
41
42>>>>>>> MERGE-SOURCE
30cur_d=${PWD}43cur_d=${PWD}
31my_d=$(dirname $(readlink -f ${0}))44my_d=$(dirname $(readlink -f ${0}))
3245
3346
=== modified file 'live-build/ubuntu-cpc/hooks/042-vagrant.binary'
--- live-build/ubuntu-cpc/hooks/042-vagrant.binary 2017-02-16 17:04:07 +0000
+++ live-build/ubuntu-cpc/hooks/042-vagrant.binary 2017-02-28 06:31:36 +0000
@@ -15,6 +15,15 @@
15# some packages in it, convert it to a vmdk, and then assemble the vagrant15# some packages in it, convert it to a vmdk, and then assemble the vagrant
16# box.16# box.
1717
18case $IMAGE_TARGETS in
19 ""|*vagrant*)
20 ;;
21 *)
22 echo "Skipping Vagrant image build"
23 exit 0
24 ;;
25esac
26
18cur_d=${PWD}27cur_d=${PWD}
19my_d=$(dirname $(readlink -f ${0}))28my_d=$(dirname $(readlink -f ${0}))
2029

Subscribers

People subscribed via source and target branches