Merge lp:~vorlon/livecd-rootfs/image-flavors into lp:livecd-rootfs

Proposed by Steve Langasek
Status: Merged
Merged at revision: 1462
Proposed branch: lp:~vorlon/livecd-rootfs/image-flavors
Merge into: lp:livecd-rootfs
Diff against target: 117 lines (+53/-1) (has conflicts)
6 files modified
debian/changelog (+3/-0)
live-build/ubuntu-cpc/hooks/032-root-squashfs.binary (+9/-0)
live-build/ubuntu-cpc/hooks/040-qcow2-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/040-vmdk-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary (+14/-1)
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+9/-0)
Text conflict in live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary
To merge this branch: bzr merge lp:~vorlon/livecd-rootfs/image-flavors
Reviewer Review Type Date Requested Status
Dan Watkins (community) Approve
Adam Conrad Pending
Review via email: mp+316530@code.launchpad.net
To post a comment you must log in.
1458. By Steve Langasek

Fix gratuitous quoting bug

Revision history for this message
Dan Watkins (oddbloke) wrote :

LGTM

review: Approve
1459. By Steve Langasek

Always export LB_IMAGE_FLAVORS, so that hooks don't complain about unbound variables

1460. By Steve Langasek

Per discussion with Adam, don't make this an LB_ variable since it's not actually part of live-build; instead we will look to pass it into the environment through launchpad-buildd

1461. By Steve Langasek

vmdk-ova has to key on the vmdk image build

1462. By Steve Langasek

Also make squashfs skippable with $IMAGE_TARGETS

1463. By Steve Langasek

merge from trunk

Revision history for this message
Colin Watson (cjwatson) :
Revision history for this message
Colin Watson (cjwatson) :
1464. By Steve Langasek

fix the changelog to match the implementation, thanks to Colin for catching

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2017-02-17 22:30:31 +0000
3+++ debian/changelog 2017-02-28 06:31:36 +0000
4@@ -7,6 +7,9 @@
5 * live-build/ubuntu-cpc/functions: umount_partition: don't call
6 umount_settle for each submount; just unmount them one by one and
7 settle at the end.
8+ * Support passing IMAGE_TARGETS in the environment, to limit which images
9+ are output as part of a build; particularly useful for ubuntu-cpc builds
10+ which output multiple image types.
11
12 [ Nishanth Aravamudan ]
13 * live-build/ubuntu-cpc/hooks/061-open-iscsi.chroot: generate iSCSI
14
15=== modified file 'live-build/ubuntu-cpc/hooks/032-root-squashfs.binary'
16--- live-build/ubuntu-cpc/hooks/032-root-squashfs.binary 2016-06-09 09:47:25 +0000
17+++ live-build/ubuntu-cpc/hooks/032-root-squashfs.binary 2017-02-28 06:31:36 +0000
18@@ -3,6 +3,15 @@
19 #
20 # Generate a squashfs root and manifest
21
22+case $IMAGE_TARGETS in
23+ ""|*squashfs*)
24+ ;;
25+ *)
26+ echo "Skipping squashfs build"
27+ exit 0
28+ ;;
29+esac
30+
31 if [ -n "$SUBARCH" ]; then
32 echo "Skipping rootfs build for subarch flavor build"
33 exit 0
34
35=== modified file 'live-build/ubuntu-cpc/hooks/040-qcow2-image.binary'
36--- live-build/ubuntu-cpc/hooks/040-qcow2-image.binary 2016-06-09 09:47:25 +0000
37+++ live-build/ubuntu-cpc/hooks/040-qcow2-image.binary 2017-02-28 06:31:36 +0000
38@@ -1,5 +1,14 @@
39 #!/bin/bash -ex
40
41+case $IMAGE_TARGETS in
42+ ""|*qcow2*)
43+ ;;
44+ *)
45+ echo "Skipping qcow2 image build"
46+ exit 0
47+ ;;
48+esac
49+
50 case $ARCH:$SUBARCH in
51 # Not sure if any other cloud images use subarch for something that
52 # should take qcow2 format, so only skipping this on raspi2 for now.
53
54=== modified file 'live-build/ubuntu-cpc/hooks/040-vmdk-image.binary'
55--- live-build/ubuntu-cpc/hooks/040-vmdk-image.binary 2016-06-09 09:47:25 +0000
56+++ live-build/ubuntu-cpc/hooks/040-vmdk-image.binary 2017-02-28 06:31:36 +0000
57@@ -9,6 +9,15 @@
58 exit 0;;
59 esac
60
61+case ${IMAGE_TARGETS:-} in
62+ ""|*vmdk*)
63+ ;;
64+ *)
65+ echo "Skipping VMDK image build"
66+ exit 0
67+ ;;
68+esac
69+
70 . /build/config/functions
71
72 if [ -e binary/boot/disk-uefi.ext4 ]; then
73
74=== modified file 'live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary'
75--- live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary 2017-02-16 17:04:07 +0000
76+++ live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary 2017-02-28 06:31:36 +0000
77@@ -26,7 +26,20 @@
78 echo "OVA images are not supported for $ARCH yet.";
79 exit 0;;
80 esac
81-
82+<<<<<<< TREE
83+
84+=======
85+
86+case ${IMAGE_TARGETS:-} in
87+ ""|*vmdk*)
88+ ;;
89+ *)
90+ echo "Skipping OVA image build"
91+ exit 0
92+ ;;
93+esac
94+
95+>>>>>>> MERGE-SOURCE
96 cur_d=${PWD}
97 my_d=$(dirname $(readlink -f ${0}))
98
99
100=== modified file 'live-build/ubuntu-cpc/hooks/042-vagrant.binary'
101--- live-build/ubuntu-cpc/hooks/042-vagrant.binary 2017-02-16 17:04:07 +0000
102+++ live-build/ubuntu-cpc/hooks/042-vagrant.binary 2017-02-28 06:31:36 +0000
103@@ -15,6 +15,15 @@
104 # some packages in it, convert it to a vmdk, and then assemble the vagrant
105 # box.
106
107+case $IMAGE_TARGETS in
108+ ""|*vagrant*)
109+ ;;
110+ *)
111+ echo "Skipping Vagrant image build"
112+ exit 0
113+ ;;
114+esac
115+
116 cur_d=${PWD}
117 my_d=$(dirname $(readlink -f ${0}))
118

Subscribers

People subscribed via source and target branches