Crucially: please call the option
revision_mail_headers
and document it in the docstring in __init__.py - thats where the help
for 'bzr help email' is sourced. I think there are some docs in README
too, that are duplicated but should be kept in sync.
Smaller things:
Characters are nearly free: s/xhdrs/extra_mail_headers/ throughout
please: the 8 bit days are long gone ;)
A test case for this would be great.
In the sending function you do
xhdrs = self.extra_headers()
....
(
, xhdrs)
and don't use the variable at all. Please just call it when you call the
lower level function.
review: needsfixing
One crucial thing, three smaller.
Crucially: please call the option mail_headers
revision_
and document it in the docstring in __init__.py - thats where the help
for 'bzr help email' is sourced. I think there are some docs in README
too, that are duplicated but should be kept in sync.
Smaller things: extra_mail_ headers/ throughout
Characters are nearly free: s/xhdrs/
please: the 8 bit days are long gone ;)
A test case for this would be great.
In the sending function you do headers( )
xhdrs = self.extra_
....
(
, xhdrs)
and don't use the variable at all. Please just call it when you call the
lower level function.
-Rob