Merge lp:~vorlon/britney/britney1-noact into lp:~ubuntu-release/britney/britney1-ubuntu

Proposed by Steve Langasek
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 366
Merged at revision: 366
Proposed branch: lp:~vorlon/britney/britney1-noact
Merge into: lp:~ubuntu-release/britney/britney1-ubuntu
Diff against target: 37 lines (+14/-6)
1 file modified
britney (+14/-6)
To merge this branch: bzr merge lp:~vorlon/britney/britney1-noact
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Utkarsh Gupta Approve
Review via email: mp+438407@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Looks good, thanks for the detailed commit message.

review: Approve
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is good. Let's get this merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'britney'
--- britney 2022-11-15 21:44:22 +0000
+++ britney 2023-03-06 19:34:23 +0000
@@ -491,7 +491,13 @@
491 # and491 # and
492 #492 #
493 # only do SRU regression emails for the non default series493 # only do SRU regression emails for the non default series
494 if [ "$SERIES" != "$DEFAULT_SERIES" ]; then494 if [ -n "$NO_ACT" ]; then
495 # honor a global toggle to disable side-effects (no email, no
496 # triggering tests, no archive updating)
497 sed -i '/^EMAIL_ENABLE/ s/=.*$/= no/' "$2"
498 sed -i '/^SRUREGRESSIONEMAIL_ENABLE/ s/=.*$/= no/' "$2"
499 sed -i '/^ADT_ENABLE/ s/yes/dry-run/' "$2"
500 elif [ "$SERIES" != "$DEFAULT_SERIES" ]; then
495 sed -i '/^EMAIL_ENABLE/ s/=.*$/= no/' "$2"501 sed -i '/^EMAIL_ENABLE/ s/=.*$/= no/' "$2"
496 sed -i '/^SRUREGRESSIONEMAIL_ENABLE/ s/=.*$/= yes/' "$2"502 sed -i '/^SRUREGRESSIONEMAIL_ENABLE/ s/=.*$/= yes/' "$2"
497 fi503 fi
@@ -578,11 +584,13 @@
578 printf " done\n"584 printf " done\n"
579}585}
580586
581if option save_b1; then587if [ -z "$NO_ACT" ]; then
582 save b1588 if option save_b1; then
583fi589 save b1
584if option save || option save_b2; then590 fi
585 save b2591 if option save || option save_b2; then
592 save b2
593 fi
586fi594fi
587595
588create_uninst_report () {596create_uninst_report () {

Subscribers

People subscribed via source and target branches