Merge lp:~vorlon/britney/britney1-noact into lp:~ubuntu-release/britney/britney1-ubuntu

Proposed by Steve Langasek
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 366
Merged at revision: 366
Proposed branch: lp:~vorlon/britney/britney1-noact
Merge into: lp:~ubuntu-release/britney/britney1-ubuntu
Diff against target: 37 lines (+14/-6)
1 file modified
britney (+14/-6)
To merge this branch: bzr merge lp:~vorlon/britney/britney1-noact
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Utkarsh Gupta Approve
Review via email: mp+438407@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Looks good, thanks for the detailed commit message.

review: Approve
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is good. Let's get this merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'britney'
2--- britney 2022-11-15 21:44:22 +0000
3+++ britney 2023-03-06 19:34:23 +0000
4@@ -491,7 +491,13 @@
5 # and
6 #
7 # only do SRU regression emails for the non default series
8- if [ "$SERIES" != "$DEFAULT_SERIES" ]; then
9+ if [ -n "$NO_ACT" ]; then
10+ # honor a global toggle to disable side-effects (no email, no
11+ # triggering tests, no archive updating)
12+ sed -i '/^EMAIL_ENABLE/ s/=.*$/= no/' "$2"
13+ sed -i '/^SRUREGRESSIONEMAIL_ENABLE/ s/=.*$/= no/' "$2"
14+ sed -i '/^ADT_ENABLE/ s/yes/dry-run/' "$2"
15+ elif [ "$SERIES" != "$DEFAULT_SERIES" ]; then
16 sed -i '/^EMAIL_ENABLE/ s/=.*$/= no/' "$2"
17 sed -i '/^SRUREGRESSIONEMAIL_ENABLE/ s/=.*$/= yes/' "$2"
18 fi
19@@ -578,11 +584,13 @@
20 printf " done\n"
21 }
22
23-if option save_b1; then
24- save b1
25-fi
26-if option save || option save_b2; then
27- save b2
28+if [ -z "$NO_ACT" ]; then
29+ if option save_b1; then
30+ save b1
31+ fi
32+ if option save || option save_b2; then
33+ save b2
34+ fi
35 fi
36
37 create_uninst_report () {

Subscribers

People subscribed via source and target branches