Merge ~vorlon/britney/+git/britney2-ubuntu:no-implicit-dependency-policy into ~ubuntu-release/britney/+git/britney2-ubuntu:master

[Steve Langasek]

[Simon Quigley (tsimonq2)]

I am not a member of the Release Team, but I did take the time to review this. It does seem rational; conceptually, this will allow us to move transitions forward faster. Pragmatically, this makes Britney run a little quicker. Either way, it seems beneficial to me.

Thank you for this!

[Steve Langasek (vorlon)]

> Pragmatically, this makes Britney run a little quicker.

This is not at all guaranteed to be true. When transitions are in flight, short-circuiting at the update_excuses phase is likely to be faster than getting to the bottom of them in update_output.

[Steve Langasek (vorlon)]

This is merged now, this broken policy is actively impeding the time_t transition.

diff --git a/britney.conf b/britney.conf
index 80003ed..145c189 100644
--- a/britney.conf
+++ b/britney.conf
@@ -89,6 +89,8 @@ REMOVE_OBSOLETE   = no
 
 CHECK_BUILDD      = no
 
+IMPLICIT_DEPS     = no
+
 ADT_ENABLE        = yes
 ADT_ARCHES        = amd64 i386 armhf ppc64el arm64
 ADT_AMQP          = amqp://test_request:[e-mail]
diff --git a/britney.py b/britney.py
index 3063dd2..8d8f427 100755
--- a/britney.py
+++ b/britney.py
@@ -538,7 +538,13 @@ class Britney(object):
         self._policy_engine.add_policy(BlockPolicy(self.options, self.suite_info))
         # XXX re-enable once https://bugs.launchpad.net/launchpad/+bug/1868558 is fixed
         # self._policy_engine.add_policy(BuiltUsingPolicy(self.options, self.suite_info))
-        self._policy_engine.add_policy(ImplicitDependencyPolicy(self.options, self.suite_info))
+        # This policy is objectively terrible, it reduces britney runtime
+        # at the cost of giving only partial information about blocking
+        # packages during large transitions instead of giving full detail in
+        # update_output that the team can work through in parallel, thus
+        # dragging out complicated transitions. vorlon 20240214
+        if getattr(self.options, 'implicit_deps', 'yes') == 'yes':
+            self._policy_engine.add_policy(ImplicitDependencyPolicy(self.options, self.suite_info))
         if getattr(self.options, 'check_buildd', 'no') == 'yes':
             self._policy_engine.add_policy(BuiltOnBuilddPolicy(self.options, self.suite_info))
         self._policy_engine.add_policy(LPBlockBugPolicy(self.options, self.suite_info))