Merge ~vorlon/britney/+git/britney2-ubuntu:futz-with-email-frequency into ~ubuntu-release/britney/+git/britney2-ubuntu:master
Proposed by
Steve Langasek
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 132ffaf4653523ca5f05e1ffbc64ed61d48c3f1f | ||||
Proposed branch: | ~vorlon/britney/+git/britney2-ubuntu:futz-with-email-frequency | ||||
Merge into: | ~ubuntu-release/britney/+git/britney2-ubuntu:master | ||||
Diff against target: |
204 lines (+82/-27) 2 files modified
britney2/policies/email.py (+55/-24) tests/test_email.py (+27/-3) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Iain Lane | Approve | ||
Adam Conrad | Pending | ||
Review via email:
|
Description of the change
Refinement of the email handling about stuck packages.
Packages that are not valid candidates but also not temporarily rejected by policy should be notified about sooner than 3 days. Packages that are valid candidates but stuck because of update_output should be notified about later. Implement this more nuanced policy, per LP: #1671468.
Supersedes https:/
To post a comment you must log in.
I originally had an objection to sending email after only 1 day of a package being stuck.
Consider packages that take longer than a day to build - these will be invalid (out of date), so you'll mail before they are ready AFAICS. I don't think proposed-migration can actually tell if a package is out of date because it is still building or because it's failed to build, either, so as it stands I don't think this is fixable. That's why we currently wait at least 3 days before mailing.
On reflection, though, I think I'm okay with merging this change and we'll see if that is a problem in reality.
Would you please comment the code where you calculate last_due? That is quite difficult to reason about and it would benefit from some explanation up front. You can just push that directly yourself.