Merge lp:~voluntatefaber/slingshot/center-switcher into lp:~elementary-pantheon/slingshot/trunk

Proposed by Andrea Basso
Status: Merged
Merged at revision: 263
Proposed branch: lp:~voluntatefaber/slingshot/center-switcher
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 46 lines (+9/-7)
2 files modified
src/SlingshotView.vala (+2/-2)
src/Widgets/CategoryView.vala (+7/-5)
To merge this branch: bzr merge lp:~voluntatefaber/slingshot/center-switcher
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+121336@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :
Revision history for this message
Cody Garver (codygarver) wrote :

I read "view switcher instead of "page switcher"..

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/SlingshotView.vala'
--- src/SlingshotView.vala 2012-08-24 10:06:13 +0000
+++ src/SlingshotView.vala 2012-08-26 16:29:17 +0000
@@ -204,9 +204,9 @@
204204
205205
206 var bottom_separator1 = new Label (""); // A fake label206 var bottom_separator1 = new Label (""); // A fake label
207 bottom_separator1.set_hexpand(true);207 bottom_separator1.set_hexpand (true);
208 var bottom_separator2 = new Label (""); // A fake label208 var bottom_separator2 = new Label (""); // A fake label
209 bottom_separator2.set_hexpand(true);209 bottom_separator2.set_hexpand (true);
210 bottom.attach (bottom_separator1, 0, 0, 1, 1); // A fake label210 bottom.attach (bottom_separator1, 0, 0, 1, 1); // A fake label
211 bottom.attach (page_switcher, 1, 0, 1, 1);211 bottom.attach (page_switcher, 1, 0, 1, 1);
212 bottom.attach (bottom_separator2, 2, 0, 1, 1); // A fake label212 bottom.attach (bottom_separator2, 2, 0, 1, 1); // A fake label
213213
=== modified file 'src/Widgets/CategoryView.vala'
--- src/Widgets/CategoryView.vala 2012-08-21 17:02:33 +0000
+++ src/Widgets/CategoryView.vala 2012-08-26 16:29:17 +0000
@@ -141,8 +141,8 @@
141 page_switcher.attach (switcher, 1, 0, 1, 1);141 page_switcher.attach (switcher, 1, 0, 1, 1);
142 page_switcher.attach (bottom_separator2, 2, 0, 1, 1);142 page_switcher.attach (bottom_separator2, 2, 0, 1, 1);
143143
144 container.attach (category_switcher, 0, 0, 1, 1);144 container.attach (category_switcher, 0, 0, 1, 2);
145 container.attach (separator, 1, 0, 1, 1);145 container.attach (separator, 1, 0, 1, 2);
146 container.attach (layout, 2, 0, 1, 1);146 container.attach (layout, 2, 0, 1, 1);
147147
148 add (container);148 add (container);
@@ -320,11 +320,13 @@
320320
321 public void show_page_switcher (bool show) {321 public void show_page_switcher (bool show) {
322322
323 if (page_switcher.get_parent () == null)323 if (page_switcher.get_parent () == null)
324 view.bottom.attach (page_switcher, 1, 0, 1, 1);324 container.attach (page_switcher, 2, 1, 1, 1);
325325
326 if (show)326 if (show) {
327 page_switcher.show_all ();327 page_switcher.show_all ();
328 view.bottom.hide ();
329 }
328 else330 else
329 page_switcher.hide ();331 page_switcher.hide ();
330332

Subscribers

People subscribed via source and target branches