Merge lp:~voluntatefaber/slingshot/center-switcher into lp:~elementary-pantheon/slingshot/trunk

Proposed by Andrea Basso
Status: Merged
Merged at revision: 263
Proposed branch: lp:~voluntatefaber/slingshot/center-switcher
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 46 lines (+9/-7)
2 files modified
src/SlingshotView.vala (+2/-2)
src/Widgets/CategoryView.vala (+7/-5)
To merge this branch: bzr merge lp:~voluntatefaber/slingshot/center-switcher
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+121336@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :
Revision history for this message
Cody Garver (codygarver) wrote :

I read "view switcher instead of "page switcher"..

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/SlingshotView.vala'
2--- src/SlingshotView.vala 2012-08-24 10:06:13 +0000
3+++ src/SlingshotView.vala 2012-08-26 16:29:17 +0000
4@@ -204,9 +204,9 @@
5
6
7 var bottom_separator1 = new Label (""); // A fake label
8- bottom_separator1.set_hexpand(true);
9+ bottom_separator1.set_hexpand (true);
10 var bottom_separator2 = new Label (""); // A fake label
11- bottom_separator2.set_hexpand(true);
12+ bottom_separator2.set_hexpand (true);
13 bottom.attach (bottom_separator1, 0, 0, 1, 1); // A fake label
14 bottom.attach (page_switcher, 1, 0, 1, 1);
15 bottom.attach (bottom_separator2, 2, 0, 1, 1); // A fake label
16
17=== modified file 'src/Widgets/CategoryView.vala'
18--- src/Widgets/CategoryView.vala 2012-08-21 17:02:33 +0000
19+++ src/Widgets/CategoryView.vala 2012-08-26 16:29:17 +0000
20@@ -141,8 +141,8 @@
21 page_switcher.attach (switcher, 1, 0, 1, 1);
22 page_switcher.attach (bottom_separator2, 2, 0, 1, 1);
23
24- container.attach (category_switcher, 0, 0, 1, 1);
25- container.attach (separator, 1, 0, 1, 1);
26+ container.attach (category_switcher, 0, 0, 1, 2);
27+ container.attach (separator, 1, 0, 1, 2);
28 container.attach (layout, 2, 0, 1, 1);
29
30 add (container);
31@@ -320,11 +320,13 @@
32
33 public void show_page_switcher (bool show) {
34
35- if (page_switcher.get_parent () == null)
36- view.bottom.attach (page_switcher, 1, 0, 1, 1);
37+ if (page_switcher.get_parent () == null)
38+ container.attach (page_switcher, 2, 1, 1, 1);
39
40- if (show)
41+ if (show) {
42 page_switcher.show_all ();
43+ view.bottom.hide ();
44+ }
45 else
46 page_switcher.hide ();
47

Subscribers

People subscribed via source and target branches