Merge lp:~voldyman/switchboard-plug-networking/missing-unknown into lp:~elementary-pantheon/switchboard-plug-networking/trunk

[Akshay Shekher]

made the missing "Unknown"'s translatable.

[Rico Tzschichholz (ricotz)]

review: Disapprove

[Akshay Shekher (voldyman)]

what do i need to fix?

[Rico Tzschichholz (ricotz)]

Better fix all existing appearances of _(UNKNOWN) which is awfully wrong

[Adam Bieńkowski (donadigo)]

Okay, i think I will take care of that and totally remove the constant because it's sensless.

review: Abstain

[xapantu (xapantu)]

Thanks for pointing this out, I just pushed an equivalent fix.

Unmerged revisions

159. By Akshay Shekher on 2015-09-05

translate missing 'Unknown'

=== modified file 'src/Utils.vala'
--- src/Utils.vala	2015-08-06 13:07:20 +0000
+++ src/Utils.vala	2015-09-05 09:00:38 +0000
@@ -29,7 +29,7 @@
     public string state_to_string (NM.DeviceState state) {
         switch (state) {
             case NM.DeviceState.UNKNOWN:
-                return UNKNOWN;
+                return _(UNKNOWN);
             case NM.DeviceState.ACTIVATED:
                 return _("Connected");
             case NM.DeviceState.DISCONNECTED:
@@ -54,13 +54,13 @@
                 return _("Failed to connect");
         }
 
-        return UNKNOWN;
+        return _(UNKNOWN);
     }
 
     public string type_to_string (NM.DeviceType type) {
         switch (type) {
             case NM.DeviceType.UNKNOWN:
-                return UNKNOWN;
+                return _(UNKNOWN);
             case NM.DeviceType.ETHERNET:
                 return _("Ethernet");
             case NM.DeviceType.WIFI:
@@ -89,6 +89,6 @@
                 return _("Bridge master");
         }
 
-        return UNKNOWN;
+        return _(UNKNOWN);
     }
 }