Code review comment for lp:~vlewis/boots/vdev

Revision history for this message
David Rosenbaum (davidjrosenbaum) wrote :

In addition to the above comments (which I agree with) there are a couple of other issues:
First, the local function maxword that you added in the issubseq function I wrote is dead code and should be removed. Another problem is that the code does not use proper indentation which will cause the interpreter to crash. Lines 51-53 mix tabs and spaces and use indentation of width 8. This is incorrect in Python and the indentation width must be 4. Please use only spaces for indentation.

review: Needs Fixing

« Back to merge proposal