Code review comment for lp:~vlastimil-holer/cloud-init/opennebula

Revision history for this message
Vlastimil Holer (vlastimil-holer) wrote :

Scott, it looks great, I definitely love your code style!

From my point of view, I more agree with your former opinion not to use shell. I originally chose that option because I got normalized output with each variable on single line very easy. Also in the past it could be possible to reference variables from other variables, but this is not true since OpenNebula 4.0 (May 2013). Context variables are now single quoted and so it's impossible to reference other variables or execute external commands. Context.sh is now just plain key='value' file, which is (from historic reasons when people wrote their own contextualization shell scripts) usually sourced from shell. Now I see the only benefit in more reliable parsing then our horrible regexp.

So, it's up to you what you prefer to leave in your project at last. Both will work fine.

Also we can make a simple parser using e.g. pyparsing, but it means new dependency into cloud-init.

« Back to merge proposal