Code review comment for lp:~vladimir.p/nova/volume_type_extradata

very nice. Tests look good. Unfortunately this needs to merge with milestone-proposed, so it could use a backport. That could be a little challenging because you merged with trunk along the way. Generally what i do is

bzr merge ../trunk
bzr commit
bzr diff old=../

bzr branch trunk -r 1479 new-branch # this is where we branched milestone

cd new-branch
bzr diff old=../trunk ../volume_type_extradata | patch -p0
bzr commit
bzr push --overwrite lp:~vladimir.p/nova/volume_type_extradata

That should have all your changes in one commit based of of 1479. That way we can apply it to both trunk and milestone cleanly.

Aside from that looks great.