On 11/11/2013 02:05 PM, Alexey Kopytov wrote:
> Vlad,
>
> "require_server_version_higher_than '5.6.10'" ensures that the test is only run with xtrabackup_56 as the XtraBackup binary. If it wasn't the case, a lot of other tests would fail too. Thus checks for xtrabackup_56 (and thus, the function) are redundant, please remove them.
>
This is true for our default use case but this is not true for common
case. "require_server_version_higher_than" checks only server version.
If "XB_BUILD" variable is set to "autodetect"(default value) then
xtrabackup binary name is chosen based on server version(see
get_version_info()). But the default value and consequently xtrabackup
binary name can be changed with "-c" option of "run.sh".
On 11/11/2013 02:05 PM, Alexey Kopytov wrote: server_ version_ higher_ than '5.6.10'" ensures that the test is only run with xtrabackup_56 as the XtraBackup binary. If it wasn't the case, a lot of other tests would fail too. Thus checks for xtrabackup_56 (and thus, the function) are redundant, please remove them.
> Vlad,
>
> "require_
>
This is true for our default use case but this is not true for common server_ version_ higher_ than" checks only server version. (default value) then info()) . But the default value and consequently xtrabackup
case. "require_
If "XB_BUILD" variable is set to "autodetect"
xtrabackup binary name is chosen based on server version(see
get_version_
binary name can be changed with "-c" option of "run.sh".