Code review comment for lp:~vlad-lesin/percona-xtrabackup/2.1-bug-1227240

On 11/11/2013 07:32 AM, Alexey Kopytov wrote:
> Review: Needs Fixing
>
> Vlad,
>
> If you have require_* calls at the start, why do you need other checks at the end of the test (and a separate function)?
>

As the test requires archived logs enabled the check is the same as for
xb_apply_archived_logs.sh. "require_xtradb" checks only the fact that
xtrabackup is built with xtradb, but it does not examine the version of
built-in xtradb. Archived logs applying is enabled only in xtradb 5.6.

Additional function was involved for better code readability from my
point of view.