Merge lp:~vlad-lesin/percona-xtrabackup/2.0-bug1179193 into lp:percona-xtrabackup/2.0

Proposed by Vlad Lesin on 2013-05-23
Status: Work in progress
Proposed branch: lp:~vlad-lesin/percona-xtrabackup/2.0-bug1179193
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 19 lines (+0/-9)
1 file modified
patches/innodb56.patch (+0/-9)
To merge this branch: bzr merge lp:~vlad-lesin/percona-xtrabackup/2.0-bug1179193
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) 2013-05-23 Needs Fixing on 2013-05-23
Review via email: mp+165301@code.launchpad.net
To post a comment you must log in.
Alexey Kopytov (akopytov) wrote :

Many failed tests in the innodb56 configuration due to segfaulting xtrabackup binary on --prepare. For example, all tests here fail due to a crash in xtrabackup: http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.0-param/444/BUILD_TYPE=release,Host=ubuntu-lucid-32bit,xtrabackuptarget=innodb56/

review: Needs Fixing

Unmerged revisions

559. By Vlad Lesin on 2013-05-14

Bug #1179193 fix.

Remove from innodb56.patch fix which disabled invoking
of fts_optimize_start_shutdown() in the case if srv_apply_log_only
is set.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'patches/innodb56.patch'
--- patches/innodb56.patch 2013-05-16 18:01:50 +0000
+++ patches/innodb56.patch 2013-05-23 08:20:36 +0000
@@ -1072,15 +1072,6 @@
1072 srv_was_started = TRUE;1072 srv_was_started = TRUE;
1073 1073
1074 return(DB_SUCCESS);1074 return(DB_SUCCESS);
1075@@ -2794,7 +2812,7 @@
1076 return(DB_SUCCESS);
1077 }
1078
1079- if (!srv_read_only_mode) {
1080+ if (!srv_read_only_mode && !srv_apply_log_only) {
1081 /* Shutdown the FTS optimize sub system. */
1082 fts_optimize_start_shutdown();
1083
1084--- a/storage/innobase/trx/trx0rseg.cc1075--- a/storage/innobase/trx/trx0rseg.cc
1085+++ b/storage/innobase/trx/trx0rseg.cc1076+++ b/storage/innobase/trx/trx0rseg.cc
1086@@ -121,9 +121,11 @@1077@@ -121,9 +121,11 @@

Subscribers

People subscribed via source and target branches