Code review comment for lp:~vlad-lesin/percona-server/sql_timeout
Revision history for this message
| Vadim Tkachenko (vadim-tk) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Vlad,
We need to have GLOBAL variable also, that's my bad, I did not think
about it initially.
I updated blueprint.
On Tue, Feb 7, 2012 at 4:10 AM, Vladislav Lesin <email address hidden> wrote:
> Review: Resubmit
>
> Everything is done except making SQL_TIMEOUT not only session but global variable too. Because blueprint describes it as a session variable. It's not an issue to do this but in this case we should change the blueprint too.
>
> Each item in the queue has a pointer to the thread object to have
> ability to invoke "kill query" function for that thread. Every time we use sql_timeout we push that pointer and expiration time to the queue. And after the query is executed we remove the item from the queue. The "remove" operation searches the queue item with certain thread pointer using hash table.
> --
> https:/
> You are reviewing the proposed merge of lp:~vlad-lesin/percona-server/sql_timeout into lp:percona-server.
--
Vadim Tkachenko, CTO, Percona Inc.
Phone +1-925-400-7377, Skype: vadimtk153
Schedule meeting: http://
Join us at Percona Live: MySQL Conference And Expo 2012
http://