Code review comment for lp:~vlad-lesin/percona-server/sql_timeout

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote :

Is it keyword because we use it in comment ?

On Tue, Jan 24, 2012 at 10:33 AM, Vladislav Lesin <email address hidden> wrote:
> Review: Needs Information
>
>> The name of option should be the same in all case.
>>
>> If it is:
>> SET SESSION SQL_TIMEOUT = 100;
>>
>> Then it should be:
>>   SELECT SLEEP(20) /*! SQL_TIMEOUT = 10 */;
>
> Ok. Done.
>
> But when you use this variant of "set" statement you have to wrap the variable name with `` (SET SESSION `SQL_TIMEOUT` = 10) because this name coincides with the keyword. It's the common rule when a variable name coincides with a keyword.
>
> Is it acceptable?
> --
> https://code.launchpad.net/~vlad-lesin/percona-server/sql_timeout/+merge/89693
> Your team Percona developers is subscribed to branch lp:percona-server.

--
Vadim Tkachenko, CTO, Percona Inc.
Phone +1-925-400-7377,  Skype: vadimtk153
Schedule meeting: http://tungle.me/VadimTkachenko

Join us at Percona Live: MySQL Conference And Expo 2012
http://www.percona.com/live/mysql-conference-2012/

« Back to merge proposal