Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~vlad-lesin/percona-server/per_query_variables_setting

  1. per_query_variables_setting
  2. Merge into 5.5
Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

> Vlad,
>
> Also why was the syntax changed to "SET PER_STATEMENT", whereas the original
> patch had "SET STATEMENT"?
>
> SET STATEMENT follows the current logic of possible SET modifiers (i.e.
> "GLOBAL", "SESSION"), i.e. you specify the scope of the variable being set.
> But PER_STATEMENT is not in line with that naming.

That's because of some tests were failed due to intersection the "STATEMENT" keyword with one of the possible values of binlog_format variable (set binlog_format=STATEMENT).

Reply

« Back to merge proposal