Code review comment for lp:~vlad-lesin/percona-server/per_query_variables_setting

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Vlad,

Also why was the syntax changed to "SET PER_STATEMENT", whereas the original patch had "SET STATEMENT"?

SET STATEMENT follows the current logic of possible SET modifiers (i.e. "GLOBAL", "SESSION"), i.e. you specify the scope of the variable being set. But PER_STATEMENT is not in line with that naming.

review: Needs Fixing

« Back to merge proposal