before calling create_log_files_rename() in case the log files are being resized.
Other calls of create_log_files_rename() don't need that, so doing it unconditionally inside create_log_files_rename() does not look right.
I'd also add a comment in that code explaining that create_log_files() can increase system LSN, so we have to update FIL_PAGE_FILE_FLUSH_LSN in data files.
Please also add the bug # reference and fix typos in revision comments before resubmitting.
I think a more correct fix would be to do:
max_flushed_lsn = log_get_lsn(); flushed_ lsn_to_ data_files( max_flushed_ lsn, 0); file_spaces( FIL_TABLESPACE) ;
fil_write_
fil_flush_
before calling create_ log_files_ rename( ) in case the log files are being resized.
Other calls of create_ log_files_ rename( ) don't need that, so doing it unconditionally inside create_ log_files_ rename( ) does not look right.
I'd also add a comment in that code explaining that create_log_files() can increase system LSN, so we have to update FIL_PAGE_ FILE_FLUSH_ LSN in data files.
Please also add the bug # reference and fix typos in revision comments before resubmitting.