Code review comment for lp:~vlad-lesin/percona-server/5.6-xtrabackup-apply-logs-fixes

Revision history for this message
Alexey Kopytov (akopytov) wrote :

I think a more correct fix would be to do:

max_flushed_lsn = log_get_lsn();
fil_write_flushed_lsn_to_data_files(max_flushed_lsn, 0);
fil_flush_file_spaces(FIL_TABLESPACE);

before calling create_log_files_rename() in case the log files are being resized.

Other calls of create_log_files_rename() don't need that, so doing it unconditionally inside create_log_files_rename() does not look right.

I'd also add a comment in that code explaining that create_log_files() can increase system LSN, so we have to update FIL_PAGE_FILE_FLUSH_LSN in data files.

Please also add the bug # reference and fix typos in revision comments before resubmitting.

review: Needs Fixing

« Back to merge proposal