Code review comment for lp:~vlad-lesin/percona-server/5.6-gtid-deployment-step

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

    - The testcase needs a test for scenario: slave: gtid_mode=on
      step=either setting, master gtid_mode=on, and step goes from on
      to off dynamically. One question here is whether we need to
      perform a binlog rotation on the change of this variable? I
      guess we don't, since we don't change the gtid_mode setting
      itself, but I'm not too sure here.
    - Do we support step going from off to on dynamically? The use
      case does not seem to require it, so might be safe to document
      this as unsupported (the deployment procedure would change this
      variable offline, at the same time gtid_mode is set to ON)
    - The blueprint needs description of dynamic step variable
      behavior, i.e. what it blocks.
- Four minor diff comments

review: Needs Fixing

« Back to merge proposal