Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~vlad-lesin/percona-server/5.1-bug1049871-injections-gca

  1. 5.1-bug1049871-injections-gca
  2. Merge into 5.1
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

   - QUOTED_IDENTIFIED macro definition should use the do { ... }
     while(0) idiom. Also, it is duplicated three times in the
     patch.
   - Lines 1074--1075 formatting issue.
   - The patch is missing
     mysql-test/suite/rpl/t/rpl_mdev382.test|result. Is this intentional?

review: Needs Fixing

« Back to merge proposal