Code review comment for lp:~vkolesnikov/pbxt/pbxt-type-enum

On May 29, 2009, at 1:03 PM, Vladimir Kolesnikov wrote:

> ok, I will check.

Thanks.

> My first guess was that this is a MySQL problem
> because pbxt is not a normal database (?)...

Yes, it is not a normal database however, I still expect it to work
because all tests end with "drop database pbxt".

Since the other tests do not indicate a problem, there must be
something different happening in this case.

So I would be interested to find out what.

A bit of background:

MySQL drops the database by dropping all the tables in the database,
and then removing the database folder.

PBXT allows the "statistics" and "location" tables to be dropped if
there are no existing PBXT tables.

Note statistics and location are normal tables from the MySQL point of
view. They both have .frm files.

When the last system table is dropped, PBXT also removes the "system"
and "data" folders in the pbxt directory.

In this way the pbxt directory should then be empty and MySQL should
be able to remove it.

> Paul McCullagh wrote:
>> I have seen this kind of thing before. I think it is a bug, and
>> should
>> be investigated.
>>
>> I all PBXT tables are dropped first, the it should always be possible
>> to do:
>>
>> drop database pbxt;
>>
>> On May 29, 2009, at 12:36 PM, Vladimir Kolesnikov wrote:
>>
>>
>>> yes, the problem was I got an error like: cannot drop dtabase pbxt,
>>> cannot delete table "statistics,locations"
>>>
>>> Paul McCullagh wrote:
>>>
>>>> Hi Vlad,
>>>>
>>>> Was there a reason for removing "drop database pbxt"?
>>>>
>>>> This change was required by MariaDB which tests that the state of
>>>> the
>>>> server is the same as before and after each test.
>>>>
>>>> On May 29, 2009, at 10:40 AM, Vladimir Kolesnikov wrote:
>>>>
>>>>
>>>>
>>>>> --disable_query_log
>>>>> -drop database pbxt;
>>>>> ---enable_query_log
>>>>> +#--disable_query_log
>>>>> +#drop database pbxt;
>>>>> +#--enable_query_log
>>>>> --echo End of 5.1 tests
>>>>>
>>>>>
>>>>
>>>> --
>>>> Paul McCullagh
>>>> PrimeBase Technologies
>>>> www.primebase.org
>>>> www.blobstreaming.org
>>>> pbxt.blogspot.com
>>>>
>>>>
>>>>
>>>>
>>>>
>>> --
>>> --
>>> Best Regards,
>>> Vladimir
>>>
>>> https://code.launchpad.net/~vkolesnikov/pbxt/pbxt-type-enum/+merge/
>>> 6878
>>> Your team PBXT Core is subscribed to branch lp:pbxt.
>>>
>>
>>
>>
>> --
>> Paul McCullagh
>> PrimeBase Technologies
>> www.primebase.org
>> www.blobstreaming.org
>> pbxt.blogspot.com
>>
>>
>>
>>
>
>
> --
> --
> Best Regards,
> Vladimir
>
> https://code.launchpad.net/~vkolesnikov/pbxt/pbxt-type-enum/+merge/
> 6878
> Your team PBXT Core is subscribed to branch lp:pbxt.

--
Paul McCullagh
PrimeBase Technologies
www.primebase.org
www.blobstreaming.org
pbxt.blogspot.com