Code review comment for lp:~vkolesnikov/pbxt/pbxt-locklist

Revision history for this message
Vladimir Kolesnikov (vkolesnikov) wrote :

Ok, I pushed the update. Please note that to keep the list of thread lock I use a statically allocated array inside of the XTThread structure. This is needed because memory allocation code uses locks and I didn't want to make any exclusions in lock accounting. Strictly speaking, it would be possible to allocate several slots at at time so subsequent slot allocation requests don't require calls to malloc code, but that looked a bit overcomplicated for me... After all, I don't think a thread will ever keep more than 3-4 locks... At the moment there is place for 50 locks (pointers) per thread.

« Back to merge proposal