Code review comment for lp:~vkolesnikov/pbxt/pbxt-heap-corruption

Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Hi Vlad,

This patch:

On May 27, 2009, at 5:40 PM, Vladimir Kolesnikov wrote:

> if (table_pool->opt_locked && !table_pool->opt_flushing) {
> - table_pool->opt_total_open--;
> /* Table will be closed below: */
> - if (table_pool->opt_total_open > 0)
> + if (table_pool->opt_total_open == 1)
> flush_table = FALSE;
> }

reverse the original logic.

Previously the table was only flushed when the last open table object
was closed.

Now it has been changed to, the table is always flushed, but not when
the last open table object is closed.

Was there are reason for changing this?

--
Paul McCullagh
PrimeBase Technologies
www.primebase.org
www.blobstreaming.org
pbxt.blogspot.com

« Back to merge proposal