Code review comment for lp:~vkolesnikov/pbxt/pbxt-drizzle-merge

Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Hi Vlad,

This was moved into the try block.

But you did not remove the copy before the try block. I assume you
just forgot...

Was it moved because of clobber warnings?

On Mar 26, 2009, at 9:55 AM, Vladimir Kolesnikov wrote:

> /* Can't do this here yet, because I need a THD! */
> try_(b) {
> + /* {MYSQL QUIRK}
> + * Sometime we have a THD,
> + * sometimes we don't.
> + * So far, I have noticed that during INSTALL PLUGIN,
> + * we have one, otherwize not.
> + */
> + if (!curr_thd) {
> + if (!(thd = (THD *) myxt_create_thread()))
> + xt_throw(self);
> + }
> +

--
Paul McCullagh
PrimeBase Technologies
www.primebase.org
www.blobstreaming.org
pbxt.blogspot.com

« Back to merge proposal