Code review comment for lp:~vjsamuel/drizzle/rplugin-innobase

The UNIV_LOG_ARCHIVE #ifdef should not be removed. It's not something we want end users seeing. It is *always* a bad idea to set this (unless you're an InnoDB hacker).

I don't see innobase_data_home_dir being freed (or a bunch of the other ones actually)

innobase_additional_mem_pool_size/= 1024;
166 + innobase_additional_mem_pool_size*= 1024;

you meant innobase_additional_mem_pool_size -= innobase_additional_mem_pool_size % 1024 ?
as the above just looks a bit odd.

         "Enable InnoDB checksums validation (enabled by default). Disable with --skip-innodb-checksums.

needs to be fixed

+ "Speeds up the shutdown process of the InnoDB storage engine. Possible values are(faster) or 2 (fastest - crash-like).");

missing the "1"