Code review comment for lp:~vjsamuel/drizzle/refactor-drizzle

Revision history for this message
Monty Taylor (mordred) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/03/2010 04:10 PM, Stewart Smith wrote:
> On Thu, 03 Jun 2010 10:41:05 -0000, Vijay Samuel <email address hidden> wrote:
>> + return make_pair("password", "☃PASSWORD☃");
>
> snowman? special characters probably shouldn't be in source.

We needed a sentinel string that was very unlikely to actually be used
in a password string. (side effect to how the program_options works) ...
This is our work around to mark the option as "didn't provide an option
- - please prompt for password"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwIQKMACgkQ2Jv7/VK1RgE87gCghfiHJ1+1tmhpZYg+kXdmPACv
GjMAoMV/0x9mvIEwhP9CBfm/JbXih64b
=QFpi
-----END PGP SIGNATURE-----

« Back to merge proposal