Code review comment for lp:~vjsamuel/drizzle/refactor-drizzle

Revision history for this message
Monty Taylor (mordred) wrote :

Mentioned on IRC, but for the record:

  error=sql_connect((char *)current_host.c_str(), (char *)current_db.c_str(), (char *)current_user.c_str(), (char *)opt_password.c_str(),0);

it might be nicer to change the sql_connect function to take arguments of const string& for host, db and current_user.

review: Needs Fixing

« Back to merge proposal