Merge lp:~vitaly-v-ch/bzr-vimdiff/cvv into lp:bzr-vimdiff

Proposed by vitaly.v.ch
Status: Work in progress
Proposed branch: lp:~vitaly-v-ch/bzr-vimdiff/cvv
Merge into: lp:bzr-vimdiff
Diff against target: 12 lines (+1/-1)
1 file modified
__init__.py (+1/-1)
To merge this branch: bzr merge lp:~vitaly-v-ch/bzr-vimdiff/cvv
Reviewer Review Type Date Requested Status
Bazaar Developers Pending
Review via email: mp+28554@code.launchpad.net

Description of the change

old and new files located like qdiff

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

vitaly.v.ch wrote:
> vitaly.v.ch has proposed merging lp:~vitaly-v-ch/bzr-vimdiff/cvv into lp:bzr-vimdiff.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
>
> old and new files located like qdiff
>

Personally, I intentionally put the file-to-edit on the left, because
that is the buffer that you start in. Which means that as soon as you
start up, you can edit the file, rather than having to start by
switching to the second window.

I would be okay with a flag for this, but I really do prefer the
file-to-edit on the left.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwmAIoACgkQJdeBCYSNAAPzWACfelrt6xhtGq+HiE8AB/zsKtsp
EmAAniQ/pjUzL/kcvJgsUxmF9HsOb3Jq
=lk5/
-----END PGP SIGNATURE-----

Revision history for this message
vitaly.v.ch (vitaly-v-ch) wrote :

Hm, may I will add config option for in in future.

\\wbr Vitaly Chernookiy

On Sat, Jun 26, 2010 at 4:31 PM, John A Meinel <email address hidden> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> vitaly.v.ch wrote:
>> vitaly.v.ch has proposed merging lp:~vitaly-v-ch/bzr-vimdiff/cvv into lp:bzr-vimdiff.
>>
>> Requested reviews:
>>   Bazaar Developers (bzr)
>>
>>
>> old and new files located like qdiff
>>
>
> Personally, I intentionally put the file-to-edit on the left, because
> that is the buffer that you start in. Which means that as soon as you
> start up, you can edit the file, rather than having to start by
> switching to the second window.
>
> I would be okay with a flag for this, but I really do prefer the
> file-to-edit on the left.
>
> John
> =:->
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Cygwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkwmAIoACgkQJdeBCYSNAAPzWACfelrt6xhtGq+HiE8AB/zsKtsp
> EmAAniQ/pjUzL/kcvJgsUxmF9HsOb3Jq
> =lk5/
> -----END PGP SIGNATURE-----
> --
> https://code.launchpad.net/~vitaly-v-ch/bzr-vimdiff/cvv/+merge/28554
> You are the owner of lp:~vitaly-v-ch/bzr-vimdiff/cvv.
>

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi Vitaly,

> Hm, may I will add config option for in in future.
I'll setting this back to Work In Progress for the moment. Looking forward to your patch :)

Cheers,

Jelmer

> \\wbr Vitaly Chernookiy
>
> On Sat, Jun 26, 2010 at 4:31 PM, John A Meinel <email address hidden> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > vitaly.v.ch wrote:
> >> vitaly.v.ch has proposed merging lp:~vitaly-v-ch/bzr-vimdiff/cvv into lp
> :bzr-vimdiff.
> >>
> >> Requested reviews:
> >>   Bazaar Developers (bzr)
> >>
> >>
> >> old and new files located like qdiff
> >>
> >
> > Personally, I intentionally put the file-to-edit on the left, because
> > that is the buffer that you start in. Which means that as soon as you
> > start up, you can edit the file, rather than having to start by
> > switching to the second window.
> >
> > I would be okay with a flag for this, but I really do prefer the
> > file-to-edit on the left.
> >
> > John
> > =:->
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.9 (Cygwin)
> > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> >
> > iEYEARECAAYFAkwmAIoACgkQJdeBCYSNAAPzWACfelrt6xhtGq+HiE8AB/zsKtsp
> > EmAAniQ/pjUzL/kcvJgsUxmF9HsOb3Jq
> > =lk5/
> > -----END PGP SIGNATURE-----
> > --
> > https://code.launchpad.net/~vitaly-v-ch/bzr-vimdiff/cvv/+merge/28554
> > You are the owner of lp:~vitaly-v-ch/bzr-vimdiff/cvv.
> >

Revision history for this message
vitaly.v.ch (vitaly-v-ch) wrote :

LinkedIn
------------

I'd like to add you to my professional network on LinkedIn.

- Vitaly

Vitaly Chernooky
Senior Software Engineer at GlobalLogic
Ukraine

Confirm that you know Vitaly Chernooky:
https://www.linkedin.com/e/-bhhzug-h71n7puy-5t/isd/8629426412/bVM9Uitq/?hs=false&tok=0hWC1m9d-HIlo1

--
You are receiving Invitation to Connect emails. Click to unsubscribe:
http://www.linkedin.com/e/-bhhzug-h71n7puy-5t/vavxsL4uPq_65Io3vuodCdRRc4xZcnqPpzkcKO5lTZ/goo/mp%2B28554%40code%2Elaunchpad%2Enet/20061/I2902414468_1/?hs=false&tok=12RHXdGK-HIlo1

(c) 2012 LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA.

Unmerged revisions

18. By vitaly.v.ch

Старый и новый файл располагаются как в qdiff

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '__init__.py'
2--- __init__.py 2007-07-13 01:34:55 +0000
3+++ __init__.py 2010-06-26 10:22:31 +0000
4@@ -129,7 +129,7 @@
5
6 def run_vimdiff(vimdiff_args, new_file_path, old_file_path):
7 import subprocess
8- sub = subprocess.call(vimdiff_args + [new_file_path, old_file_path])
9+ sub = subprocess.call(vimdiff_args + [old_file_path, new_file_path])
10
11
12 register_command(cmd_gvimdiff)

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: