Code review comment for lp:~vishvananda/nova/remove-network-index

Revision history for this message
Jay Pipes (jaypipes) wrote :

"1) Where do networks get disassociated? Right now I'm not disassociating at all. We're sharing ldap users across different deploys, whereas sql db is unique per deploy. Perhaps the solution is to have a flag like disassociate_on_project_destroy and make it optional?"

I think that is an excellent option. ++ on a flag to determine when disassociation occurs.

"2) How do we handle creation of networks for tests? It is really slow to create a pool of networks and fixed_ips for each test case. Right now I'm taking advantage of the fact that the db isn't cleaned between tests, and creating them if they don't exist in BaseTestCase.SetUp() and disassociating in TearDown(). Ideally this should be replaced with fixtures of some sort."

Well, there's a ton to talk about with the current testing systems at the next summit :) I say "systems" because the new rackspace stuff is using nosetests, and the rest is using the nova.test.BaseTestCase or unittest.TestCase.

I'd love to do a discuss the future of how we test OS projects at the summit...including stuff like how we establish fixtures and configuration-dependent environments.

-jay

« Back to merge proposal