Code review comment for lp:~vishvananda/nova/network-refactor

The attempt to merge lp:~vishvananda/nova/network-refactor into lp:nova failed.Below is the output from the failed tests.

nova.tests.access_unittest
  AccessTestCase
    test_001_allow_all ... [OK]
    test_002_allow_none ... [OK]
    test_003_allow_project_manager ... [OK]
    test_004_allow_sys_and_net ... [OK]
    test_005_allow_sys_no_pm ... [OK]
nova.tests.api_unittest
  ApiEc2TestCase
    test_describe_instances ... [OK]
    test_get_all_key_pairs ... [OK]
nova.tests.auth_unittest
  AuthTestCase
    test_001_can_create_users ... [OK]
    test_002_can_get_user ... [OK]
    test_003_can_retreive_properties ... [OK]
    test_004_signature_is_valid ... [OK]
    test_005_can_get_credentials ... [OK]
    test_006_test_key_storage ... [OK]
    test_007_test_key_generation ... [OK]
    test_008_can_list_key_pairs ... [OK]
    test_009_can_delete_key_pair ... [OK]
    test_010_can_list_users ... [OK]
    test_101_can_add_user_role ... [OK]
    test_199_can_remove_user_role ... [OK]
    test_201_can_create_project ... [OK]
    test_202_user1_is_project_member ... [OK]
    test_203_user2_is_not_project_member ... [OK]
    test_204_user1_is_project_manager ... [OK]
    test_205_user2_is_not_project_manager ... [OK]
    test_206_can_add_user_to_project ... [OK]
    test_208_can_remove_user_from_project ... [OK]
    test_209_can_generate_x509 ... [OK]
    test_210_can_add_project_role ... [OK]
    test_211_can_remove_project_role ... [OK]
    test_214_can_retrieve_project_by_user ... [OK]
    test_299_can_delete_project ... [OK]
    test_999_can_delete_users ... [OK]
nova.tests.cloud_unittest
  CloudTestCase
    test_console_output ... [OK]
    test_instance_update_state ... [OK]
    test_run_instances ... [OK]
nova.tests.compute_unittest
  ComputeConnectionTestCase
    test_console_output ... [OK]
    test_reboot ... [OK]
    test_run_describe_terminate ... [OK]
    test_run_instance_existing ... [OK]
  InstanceXmlTestCase
    test_serialization ... [OK]
nova.tests.model_unittest
  ModelTestCase
    test_create_daemon_single_arg ... [OK]
    test_create_daemon_two_args ... [OK]
    test_create_host ... [OK]
    test_create_instance ... [OK]
    test_create_session_token ... [OK]
    test_daemon_added_to_set ... [OK]
    test_daemon_associates_host ... [OK]
    test_daemon_heartbeat ... [OK]
    test_delete_daemon ... [OK]
    test_delete_host ... [OK]
    test_delete_instance ... [OK]
    test_delete_session_token ... [OK]
    test_equality_daemon_of_double_and_single_args ... [OK]
    test_equality_of_daemon_single_and_double_args ... [OK]
    test_find_generated_session_token ... [OK]
    test_host_added_to_set ... [OK]
    test_host_class_doesnt_find_missing_hosts ... [OK]
    test_host_class_finds_hosts ... [OK]
    test_instance_added_to_set ... [OK]
    test_instance_associates_project ... [OK]
    test_session_token_added_to_set ... [OK]
    test_session_token_associates_user ... [OK]
    test_session_token_generation ... [OK]
    test_session_token_is_expired_when_expired ... [OK]
    test_session_token_is_expired_when_not_expired ... [OK]
    test_session_token_lookup_when_expired ... [OK]
    test_session_token_lookup_when_not_expired ... [OK]
    test_session_token_ttl ... [OK]
    test_update_session_token_expiry ... [OK]
nova.tests.network_unittest
  NetworkTestCase
    test_212_vpn_ip_and_port_looks_valid ... [OK]
    test_allocate_deallocate_fixed_ip ... [OK]
    test_deallocate_before_issued ... [OK]
    test_public_network_allocation ... [OK]
    test_range_allocation ... [OK]
    test_release_before_deallocate ... [OK]
    test_subnet_edge ... [OK]
    test_too_many_addresses ... [OK]
    test_too_many_vpns ... [ERROR]
nova.tests.objectstore_unittest
  ObjectStoreTestCase
    test_buckets ... [OK]
    test_images ... [OK]
  S3APITestCase
    test_000_list_buckets ... [OK]
    test_001_create_and_delete_bucket ... [OK]
    test_002_create_bucket_and_key_and_delete_key_again ... [OK]
nova.tests.process_unittest
  ProcessTestCase
    test_execute_stderr ... [OK]
    test_execute_stdout ... [OK]
    test_execute_unexpected_stderr ... [OK]
    test_kill_long_process ... [OK]
    test_max_processes ... [OK]
    test_process_exit_is_contained ... [OK]
    test_shared_pool_is_singleton ... [OK]
    test_shared_pool_works_as_singleton ... [OK]
nova.tests.validator_unittest
  ValidationTestCase
    test_type_validation ... [OK]
nova.tests.volume_unittest
  VolumeTestCase
    test_multi_node ... [OK]
    test_run_attach_detach_volume ... [OK]
    test_run_create_volume ... [OK]
    test_too_big_volume ... [OK]
    test_too_many_volumes ... [OK]

===============================================================================
[ERROR]: nova.tests.network_unittest.NetworkTestCase.test_too_many_vpns

Traceback (most recent call last):
  File "/var/lib/hudson/src/nova/hudson/nova/tests/network_unittest.py", line 166, in test_too_many_vpns
    for i in xrange(vpn.NetworkData.num_ports_for_ip(FLAGS.vpn_ip)):
exceptions.UnboundLocalError: local variable 'vpn' referenced before assignment
-------------------------------------------------------------------------------
Ran 97 tests in 5.325s

FAILED (errors=1, successes=96)

INFO:root:Flushing redis datastore