OpenStack Compute (nova)

Code review comment for lp:~vishvananda/nova/lp720393

  1. lp720393
  2. Merge into trunk
Revision history for this message
Soren Hansen (soren) wrote :

I don't like that we have the exact same code in two places (the exact same code is in VlanManager's periodic_tasks).

Maybe you could make it a module level function or move it into the NetworkManager class and make it conditional on a "needs_dhcp_cleanup" class variable that is set appropriately for the various managers?

« Back to merge proposal