Code review comment for lp:~vishvananda/nova/lp710959

Yes that is one of the questions I raised earlier. Can we just set LC=ALL in the environment or something? I suppose I could check for process execution error and find the exit code instead, but I'll have to verify that the exit codes are actually meaningful.

Vish

On Feb 8, 2011, at 8:16 AM, Jay Pipes wrote:

> Review: Approve
> Hi! Code looks good!
>
> One question though (that can be fixed after merge, if necessary):
>
> 57 + if err and err != "RTNETLINK answers: File exists\n":
> 58 + raise exception.Error("Failed to add ip: %s" % err)
>
> I don't think this i18n-proof. Is there a way to instead compare against an error code, instead of an English string?
>
> Approving, though, since the above can be address later.
>
> -jay
> --
> https://code.launchpad.net/~vishvananda/nova/lp710959/+merge/48341
> You are the owner of lp:~vishvananda/nova/lp710959.