Hi! Code looks good!
One question though (that can be fixed after merge, if necessary):
57 + if err and err != "RTNETLINK answers: File exists\n": 58 + raise exception.Error("Failed to add ip: %s" % err)
I don't think this i18n-proof. Is there a way to instead compare against an error code, instead of an English string?
Approving, though, since the above can be address later.
-jay
« Back to merge proposal
Hi! Code looks good!
One question though (that can be fixed after merge, if necessary):
57 + if err and err != "RTNETLINK answers: File exists\n": Error(" Failed to add ip: %s" % err)
58 + raise exception.
I don't think this i18n-proof. Is there a way to instead compare against an error code, instead of an English string?
Approving, though, since the above can be address later.
-jay