Code review comment for lp:~vishvananda/nova/lp710959

Revision history for this message
Jay Pipes (jaypipes) wrote :

Hi! Code looks good!

One question though (that can be fixed after merge, if necessary):

57 + if err and err != "RTNETLINK answers: File exists\n":
58 + raise exception.Error("Failed to add ip: %s" % err)

I don't think this i18n-proof. Is there a way to instead compare against an error code, instead of an English string?

Approving, though, since the above can be address later.

-jay

review: Approve

« Back to merge proposal